You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/07/10 05:19:51 UTC
[PR] [SPARK-58083][INFRA] Pass PyPI token to twine via environment variable in `release-build.sh` [spark]
dongjoon-hyun opened a new pull request, #57180:
URL: https://github.com/apache/spark/pull/57180
### What changes were proposed in this pull request?
This PR changes the `finalize` step of `dev/create-release/release-build.sh` to pass the PyPI API token to `twine` via the `TWINE_PASSWORD` environment variable instead of the `-p $PYPI_API_TOKEN` command-line argument. The `export` statement is wrapped with a `set +x` guard so the token is not printed when `DEBUG_MODE=1` enables shell tracing.
### Why are the changes needed?
On Linux, `/proc/<pid>/cmdline` is world-readable, so passing the token with `-p` exposes it to every user on the host during the upload. Running inside Docker (`do-release-docker.sh`) does not help: container processes are still visible to the host's `ps`. With `DEBUG_MODE=1`, the `set -x` trace also prints the token expanded in the command line into the console output and logs. Environment variables avoid both exposure paths and are the twine-recommended way to supply credentials non-interactively.
### Does this PR introduce _any_ user-facing change?
No. This only affects the release scripts.
### How was this patch tested?
Manual review.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58083][INFRA] Pass PyPI token to twine via environment variable in `release-build.sh` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #57180:
URL: https://github.com/apache/spark/pull/57180#issuecomment-4937432681
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/24f08f2cf353295166b130d43a62fd3c397c0019
- merged into branch-4.x https://github.com/apache/spark/commit/d38fde87ca91e8ad5b5af3bac6d8e19ca849882c
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58083][INFRA] Pass PyPI token to twine via environment variable in `release-build.sh` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #57180:
URL: https://github.com/apache/spark/pull/57180#issuecomment-4937424215
Thank you, @HyukjinKwon .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58083][INFRA] Pass PyPI token to twine via environment variable in `release-build.sh` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #57180: [SPARK-58083][INFRA] Pass PyPI token to twine via environment variable in `release-build.sh`
URL: https://github.com/apache/spark/pull/57180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org