You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/28 13:16:24 UTC
[GitHub] [spark] grundprinzip opened a new pull request, #38821: [SPARK-41300] [CONNECT] Unset schema is interepreted as Schema
grundprinzip opened a new pull request, #38821:
URL: https://github.com/apache/spark/pull/38821
### What changes were proposed in this pull request?
When a query is read from a DataSource using Spark Connect, the scalar string value would be empty and thus during processing we would treat it as set and fail the query because no schema can be parsed from the empty string.
This patch fixes this issue and adds the relevant test for it.
### Why are the changes needed?
Bugfix
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38821: [SPARK-41300] [CONNECT] Unset schema is interpreted as Schema
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38821:
URL: https://github.com/apache/spark/pull/38821#issuecomment-1329521047
LGTM thanks for catching this case!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #38821: [SPARK-41300] [CONNECT] Unset schema is interpreted as Schema
Posted by GitBox <gi...@apache.org>.
hvanhovell commented on PR #38821:
URL: https://github.com/apache/spark/pull/38821#issuecomment-1329261669
Merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #38821: [SPARK-41300] [CONNECT] Unset schema is interpreted as Schema
Posted by GitBox <gi...@apache.org>.
hvanhovell closed pull request #38821: [SPARK-41300] [CONNECT] Unset schema is interpreted as Schema
URL: https://github.com/apache/spark/pull/38821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org