[GitHub] [incubator-doris] xuzifu666 commented on a change in pull request #7506: [Feature] broker load disable cache config added

[GitBox <gi...@apache.org>]

xuzifu666 commented on a change in pull request #7506:
URL: https://github.com/apache/incubator-doris/pull/7506#discussion_r776578500



##########
File path: fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java
##########
@@ -419,7 +420,7 @@ public BrokerFileSystem getS3AFileSystem(String path, Map<String, String> proper
                 conf.set(FS_S3A_ACCESS_KEY, accessKey);
                 conf.set(FS_S3A_SECRET_KEY, secretKey);
                 conf.set(FS_S3A_ENDPOINT, endpoint);
-                conf.set(FS_S3A_IMPL_DISABLE_CACHE, "true");
+                conf.set(FS_S3A_IMPL_DISABLE_CACHE, disableCache);

Review comment:
       under multi process circumstances, we need set the parameter to false, avoid delete dir of other user process because the name is same conflict. for a few ago, we just encounter the circumstances. so i commit the pr, but default true to user is ok.
   https://blog.csdn.net/jyl1798/article/details/42521789 is a factor for the pr @morningman 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org