You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sis.apache.org by de...@apache.org on 2018/12/07 13:09:02 UTC
svn commit: r1848397 - in /sis/ip-review: ConvertedCategory.xhtml
ConvertedCategoryList.xhtml rev/10796/ConvertedCategory.xhtml
rev/10796/ConvertedCategoryList.xhtml rev/20970/ConvertedCategory.xhtml
rev/20970/ConvertedCategoryList.xhtml
Author: desruisseaux
Date: Fri Dec 7 13:09:01 2018
New Revision: 1848397
URL: http://svn.apache.org/viewvc?rev=1848397&view=rev
Log:
Add IP review for Geotk "GeophysicsCategory" class (renamed "ConvertedCategory").
Added:
sis/ip-review/ConvertedCategory.xhtml
sis/ip-review/ConvertedCategoryList.xhtml
sis/ip-review/rev/10796/ConvertedCategory.xhtml
sis/ip-review/rev/10796/ConvertedCategoryList.xhtml
sis/ip-review/rev/20970/ConvertedCategory.xhtml
sis/ip-review/rev/20970/ConvertedCategoryList.xhtml
Added: sis/ip-review/ConvertedCategory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/ConvertedCategory.xhtml?rev=1848397&view=auto
==============================================================================
--- sis/ip-review/ConvertedCategory.xhtml (added)
+++ sis/ip-review/ConvertedCategory.xhtml Fri Dec 7 13:09:01 2018
@@ -0,0 +1,54 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+ <head>
+ <meta charset="UTF-8"/>
+ <title>ConvertedCategory history</title>
+ <style type="text/css" media="all">
+ @import url("./reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>ConvertedCategory history</h1>
+ <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/GeophysicsCategory.java</code></blockquote>
+<table>
+ <tr>
+ <th>Rev.</th>
+ <th>Date</th>
+ <th>Author</th>
+ <th class="last">Message</th>
+ </tr>
+<tr><td class="rev">30643</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/coverage, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30541</td><td>2008-06-06</td><td>acuster</td><td>Copyright review: update headers on lib/coverage</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28852</td><td>2008-01-21</td><td>desruisseaux</td><td>Reverted back "view(ViewType)" methods to "geophysics(boolean)" in Category and GridSampleDimension because views other than "geophysics" and "packed" don't make sense in current design. However those various views still in GridCoverage2D, which can support a richer set including "photographic" because it know about all bands together (as opposite to Category/GridSampleDimension which don't know what the other bands are). Also removed a few deprecated constructors and changed ViewType constants.</td></tr>
+<tr><td class="rev">28846</td><td>2008-01-20</td><td>desruisseaux</td><td>Covariant return type for inverse() method in MathTransform1D and MathTransform2D. Also javadoc fixes and Java 5 type safety. Changed ViewType to an enum and initial implementation of GridCoverageViews (not yet connected to GridCoverage2D).</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated utilities class named 'Classes'. Also added a couple of @Override annotations.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20970</td><td>2006-08-11</td><td class="unav">jgarnett</td><td><a href="rev/20970/ConvertedCategory.xhtml">IP review.txt updated, along with headers</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16572</td><td>2005-11-02</td><td>desruisseaux</td><td>Moved coverage implementation to its own module (GEOT-745)</td></tr>
+<tr><td class="rev">15736</td><td>2005-09-19</td><td>desruisseaux</td><td>Added convenience methods or constructors</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized I18N resources</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">11549</td><td>2005-02-22</td><td>desruisseaux</td><td>Initial cleaning for restarting GridCoverage work</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/ConvertedCategory.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">8521</td><td>2004-10-11</td><td>desruisseaux</td><td>Fixed compilation errors caused by latest CRS commit</td></tr>
+<tr><td class="rev">6301</td><td>2004-06-03</td><td>desruisseaux</td><td>Refactored basic transform in their own package</td></tr>
+<tr><td class="rev">6259</td><td>2004-05-31</td><td>desruisseaux</td><td>Added more implementations for Coverage support</td></tr>
+<tr><td class="rev">6238</td><td>2004-05-28</td><td>desruisseaux</td><td>Replaced org.geotools.[...].TransformException by org.opengis.[...].TransformException</td></tr>
+<tr><td class="rev">6210</td><td>2004-05-27</td><td>desruisseaux</td><td>Javadoc fixes / Added Id keyword property</td></tr>
+<tr><td class="rev">6160</td><td>2004-05-25</td><td>desruisseaux</td><td>Initial refactoring of Category</td></tr>
+</table>
+ </div>
+ </body>
+</html>
Added: sis/ip-review/ConvertedCategoryList.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/ConvertedCategoryList.xhtml?rev=1848397&view=auto
==============================================================================
--- sis/ip-review/ConvertedCategoryList.xhtml (added)
+++ sis/ip-review/ConvertedCategoryList.xhtml Fri Dec 7 13:09:01 2018
@@ -0,0 +1,54 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+ <head>
+ <meta charset="UTF-8"/>
+ <title>ConvertedCategoryList history</title>
+ <style type="text/css" media="all">
+ @import url("./reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>ConvertedCategoryList history</h1>
+ <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/GeophysicsCategoryList.java</code></blockquote>
+<table>
+ <tr>
+ <th>Rev.</th>
+ <th>Date</th>
+ <th>Author</th>
+ <th class="last">Message</th>
+ </tr>
+<tr><td class="rev">30760</td><td>2008-06-18</td><td>desruisseaux</td><td>Upgrated from JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override annotations in the process.</td></tr>
+<tr><td class="rev">30643</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/coverage, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30541</td><td>2008-06-06</td><td>acuster</td><td>Copyright review: update headers on lib/coverage</td></tr>
+<tr><td class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few tests show that the compiler always select the best overloaded flavor working on primitive types (except if an argument is a boolean and the other a different primitive type). Updated a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28852</td><td>2008-01-21</td><td>desruisseaux</td><td>Reverted back "view(ViewType)" methods to "geophysics(boolean)" in Category and GridSampleDimension because views other than "geophysics" and "packed" don't make sense in current design. However those various views still in GridCoverage2D, which can support a richer set including "photographic" because it know about all bands together (as opposite to Category/GridSampleDimension which don't know what the other bands are). Also removed a few deprecated constructors and changed ViewType constants.</td></tr>
+<tr><td class="rev">28846</td><td>2008-01-20</td><td>desruisseaux</td><td>Covariant return type for inverse() method in MathTransform1D and MathTransform2D. Also javadoc fixes and Java 5 type safety. Changed ViewType to an enum and initial implementation of GridCoverageViews (not yet connected to GridCoverage2D).</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28500</td><td>2007-12-24</td><td>desruisseaux</td><td>Added a new GridGeometry implementation (ImageGeometry) has a lightweight placeholder for 'gridRange' as a Rectangle and 'gridToCRS' as an AffineTransform. Used by TileBuilder.</td></tr>
+<tr><td class="rev">28464</td><td>2007-12-21</td><td>desruisseaux</td><td>First draft of a TileCollection helper class. Not yet tested.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">22817</td><td>2006-11-17</td><td>desruisseaux</td><td>Fixed SVN properties for all Java files.</td></tr>
+<tr><td class="rev">22710</td><td>2006-11-12</td><td>desruisseaux</td><td>Review of coverage branch merge: In 'CategoryList', check for the 'no data' category name only if the geophysics value is some NaN value. Moved XAffineTransform to a public place and added methods for testing axis swapping, as a proposed replacement for 'GeneralGridGeometry.swapXY(CoordinateSystem)' (replacement not yet done; waiting for the okay from the mailing list). In GeneralGridGeometry, added methods for returning a math transform relative to some pixel corner instead of pixel center, as a proposed replacement for the 'getTransform(...)' public static methods (I would like to remove those static methods in order to keep the API a little bit more orthogonal).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20970</td><td>2006-08-11</td><td class="unav">jgarnett</td><td><a href="rev/20970/ConvertedCategoryList.xhtml">IP review.txt updated, along with headers</a></td></tr>
+<tr><td class="rev">20600</td><td>2006-07-18</td><td class="unav">simboss</td><td><a href="rev/20970/ConvertedCategoryList.xhtml">-committing first bunch of changes from the coverage branch. Modules involved are*api *referencing *coverage *main *renderer *shaperenderer</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16572</td><td>2005-11-02</td><td>desruisseaux</td><td>Moved coverage implementation to its own module (GEOT-745)</td></tr>
+<tr><td class="rev">15736</td><td>2005-09-19</td><td>desruisseaux</td><td>Added convenience methods or constructors</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">11549</td><td>2005-02-22</td><td>desruisseaux</td><td>Initial cleaning for restarting GridCoverage work</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/ConvertedCategoryList.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">6259</td><td>2004-05-31</td><td>desruisseaux</td><td>Added more implementations for Coverage support</td></tr>
+</table>
+ </div>
+ </body>
+</html>
Added: sis/ip-review/rev/10796/ConvertedCategory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/ConvertedCategory.xhtml?rev=1848397&view=auto
==============================================================================
--- sis/ip-review/rev/10796/ConvertedCategory.xhtml (added)
+++ sis/ip-review/rev/10796/ConvertedCategory.xhtml Fri Dec 7 13:09:01 2018
@@ -0,0 +1,80 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+ <head>
+ <meta charset="UTF-8"/>
+ <title>ConvertedCategory changes for revisions 10795:10796</title>
+ <style type="text/css" media="all">
+ @import url("../../reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>ConvertedCategory changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some <cite>"auto reformat"</cite> tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/GeophysicsCategory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>// J2SE dependencies
+import java.awt.Color;
+<span class="del">import java.util.Locale;</span>
+
+<span class="del">// OpenGIS dependencies</span>
+<span class="del">import org.opengis.util.InternationalString;</span>
+import org.opengis.referencing.FactoryException;
+import org.opengis.referencing.operation.MathTransform1D;
+import org.opengis.referencing.operation.TransformException;
+<span class="del">import org.opengis.referencing.operation.MathTransformFactory;</span>
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.util.NumberRange;</span>
+<span class="del">import org.geotools.resources.Utilities;</span>
+<span class="del">import org.geotools.resources.gcs.Resources;</span>
+<span class="del">import org.geotools.resources.gcs.ResourceKeys;</span>
+<span class="del">import org.geotools.referencing.FactoryFinder;</span>
+<span class="del">import org.geotools.referencing.operation.transform.LinearTransform1D;</span>
+
+<span class="del"></span>
+/**
+ * A "geophysics" view of a category. Sample values in this category are equal to geophysics
+ * values. By definition, the {@link #getSampleToGeophysics} method for this class returns</pre></td>
+<td><pre>// J2SE dependencies
+import java.awt.Color;
+
+<span class="add">import org.geotools.referencing.FactoryFinder;</span>
+<span class="add">import org.geotools.referencing.operation.transform.LinearTransform1D;</span>
+<span class="add">import org.geotools.resources.Utilities;</span>
+<span class="add">import org.geotools.resources.gcs.ResourceKeys;</span>
+<span class="add">import org.geotools.resources.gcs.Resources;</span>
+<span class="add">import org.geotools.util.NumberRange;</span>
+import org.opengis.referencing.FactoryException;
+import org.opengis.referencing.operation.MathTransform1D;
+<span class="add">import org.opengis.referencing.operation.MathTransformFactory;</span>
+import org.opengis.referencing.operation.TransformException;
+<span class="add">import org.opengis.util.InternationalString;</span>
+
+
+/**
+ * A "geophysics" view of a category. Sample values in this category are equal to geophysics
+ * values. By definition, the {@link #getSampleToGeophysics} method for this class returns</pre></td></tr>
+</table>
+ </div>
+ </body>
+</html>
Added: sis/ip-review/rev/10796/ConvertedCategoryList.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/ConvertedCategoryList.xhtml?rev=1848397&view=auto
==============================================================================
--- sis/ip-review/rev/10796/ConvertedCategoryList.xhtml (added)
+++ sis/ip-review/rev/10796/ConvertedCategoryList.xhtml Fri Dec 7 13:09:01 2018
@@ -0,0 +1,147 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+ <head>
+ <meta charset="UTF-8"/>
+ <title>ConvertedCategoryList changes for revisions 10795:10796</title>
+ <style type="text/css" media="all">
+ @import url("../../reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>ConvertedCategoryList changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some <cite>"auto reformat"</cite> tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/GeophysicsCategoryList.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.coverage;
+
+// J2SE dependencies
+import java.util.Locale;
+<span class="del">import java.text.NumberFormat;</span>
+<span class="del">import java.text.FieldPosition;</span>
+import javax.units.Unit;
+
+<span class="del">// Resources</span>
+import org.geotools.resources.XMath;
+<span class="del">import org.geotools.resources.Utilities;</span>
+
+
+/**</pre></td>
+<td><pre>package org.geotools.coverage;
+
+// J2SE dependencies
+<span class="add">import java.text.FieldPosition;</span>
+<span class="add">import java.text.NumberFormat;</span>
+<span class="add">import java.util.AbstractList;</span>
+import java.util.Locale;
+<span class="add"></span>
+import javax.units.Unit;
+
+<span class="add">import org.geotools.resources.Utilities;</span>
+import org.geotools.resources.XMath;
+
+
+/**</pre></td></tr>
+<tr><td><pre>private static final int MAX_DIGITS = 6;
+
+/**
+<span class="del"> * Unités des mesures géophysiques représentées par les catégories.</span>
+<span class="del"> * Ce champ peut être nul s'il ne s'applique pas ou si les unités</span>
+ * ne sont pas connues.
+ */
+private final Unit unit;
+
+/**
+<span class="del"> * Nombre de chiffres significatifs après la virgule.</span>
+<span class="del"> * Cette information est utilisée pour les écritures</span>
+<span class="del"> * des valeurs géophysiques des catégories.</span>
+ */
+private final int ndigits;</pre></td>
+<td><pre>private static final int MAX_DIGITS = 6;
+
+/**
+<span class="add"> * Unit�s des mesures g�ophysiques repr�sent�es par les cat�gories.</span>
+<span class="add"> * Ce champ peut �tre nul s'il ne s'applique pas ou si les unit�s</span>
+ * ne sont pas connues.
+ */
+private final Unit unit;
+
+/**
+<span class="add"> * Nombre de chiffres significatifs apr�s la virgule.</span>
+<span class="add"> * Cette information est utilis�e pour les �critures</span>
+<span class="add"> * des valeurs g�ophysiques des cat�gories.</span>
+ */
+private final int ndigits;</pre></td></tr>
+<tr><td><pre>private transient Locale locale;
+
+/**
+<span class="del"> * Format à utiliser pour écrire les</span>
+<span class="del"> * valeurs géophysiques des thèmes.</span>
+ */
+private transient NumberFormat format;</pre></td>
+<td><pre>private transient Locale locale;
+
+/**
+<span class="add"> * Format � utiliser pour �crire les</span>
+<span class="add"> * valeurs g�ophysiques des th�mes.</span>
+ */
+private transient NumberFormat format;</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Formatte la valeur spécifiée selon les conventions locales. Le nombre sera</span>
+<span class="del"> * écrit avec un nombre de chiffres après la virgule approprié pour la catégorie.</span>
+<span class="del"> * Le symbole des unités sera ajouté après le nombre si <code>writeUnit</code></span>
+ * est <code>true</code>.
+ *
+<span class="del"> * @param value Valeur du paramètre géophysique à formatter.</span>
+<span class="del"> * @param writeUnit Indique s'il faut écrire le symbole des unités après le nombre.</span>
+<span class="del"> * Cet argument sera ignoré si aucune unité n'avait été spécifiée au constructeur.</span>
+<span class="del"> * @param locale Conventions locales à utiliser, ou <code>null</code> pour les conventions par</span>
+<span class="del"> * défaut.</span>
+<span class="del"> * @param buffer Le buffer dans lequel écrire la valeur.</span>
+<span class="del"> * @return Le buffer <code>buffer</code> dans lequel auront été écrit la valeur et les unités.</span>
+ */
+synchronized StringBuffer format(final double value, final boolean writeUnits,
+ final Locale locale, StringBuffer buffer)</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Formatte la valeur sp�cifi�e selon les conventions locales. Le nombre sera</span>
+<span class="add"> * �crit avec un nombre de chiffres apr�s la virgule appropri� pour la cat�gorie.</span>
+<span class="add"> * Le symbole des unit�s sera ajout� apr�s le nombre si <code>writeUnit</code></span>
+ * est <code>true</code>.
+ *
+<span class="add"> * @param value Valeur du param�tre g�ophysique � formatter.</span>
+<span class="add"> * @param writeUnit Indique s'il faut �crire le symbole des unit�s apr�s le nombre.</span>
+<span class="add"> * Cet argument sera ignor� si aucune unit� n'avait �t� sp�cifi�e au constructeur.</span>
+<span class="add"> * @param locale Conventions locales � utiliser, ou <code>null</code> pour les conventions par</span>
+<span class="add"> * d�faut.</span>
+<span class="add"> * @param buffer Le buffer dans lequel �crire la valeur.</span>
+<span class="add"> * @return Le buffer <code>buffer</code> dans lequel auront �t� �crit la valeur et les unit�s.</span>
+ */
+synchronized StringBuffer format(final double value, final boolean writeUnits,
+ final Locale locale, StringBuffer buffer)</pre></td></tr>
+</table>
+ </div>
+ </body>
+</html>
Added: sis/ip-review/rev/20970/ConvertedCategory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20970/ConvertedCategory.xhtml?rev=1848397&view=auto
==============================================================================
--- sis/ip-review/rev/20970/ConvertedCategory.xhtml (added)
+++ sis/ip-review/rev/20970/ConvertedCategory.xhtml Fri Dec 7 13:09:01 2018
@@ -0,0 +1,53 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+ <head>
+ <meta charset="UTF-8"/>
+ <title>ConvertedCategory changes for revisions 20969:20970</title>
+ <style type="text/css" media="all">
+ @import url("../../reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>ConvertedCategory changes for revisions 20969:20970</h1>
+
+<p>Change in LGPL header does not apply to Apache SIS.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20969:20970 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/GeophysicsCategory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20969</th><th>Revision 20970</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ * This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> * GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> * http://geotools.org</span>
+<span class="add"> * (C) 2003-2006, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ * This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre>* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+* Lesser General Public License for more details.
+*
+<span class="del">* You should have received a copy of the GNU Lesser General Public</span>
+<span class="del">* License along with this library; if not, write to the Free Software</span>
+<span class="del">* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA</span>
+<span class="del">*</span>
+<span class="del">*</span>
+* This package contains documentation from OpenGIS specifications.
+* OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td>
+<td><pre>* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+* Lesser General Public License for more details.
+*
+* This package contains documentation from OpenGIS specifications.
+* OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td></tr>
+</table>
+ </div>
+ </body>
+</html>
Added: sis/ip-review/rev/20970/ConvertedCategoryList.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20970/ConvertedCategoryList.xhtml?rev=1848397&view=auto
==============================================================================
--- sis/ip-review/rev/20970/ConvertedCategoryList.xhtml (added)
+++ sis/ip-review/rev/20970/ConvertedCategoryList.xhtml Fri Dec 7 13:09:01 2018
@@ -0,0 +1,69 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+ <head>
+ <meta charset="UTF-8"/>
+ <title>ConvertedCategoryList changes for revisions 20599:20970</title>
+ <style type="text/css" media="all">
+ @import url("../../reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>ConvertedCategoryList changes for revisions 20599:20970</h1>
+
+<p>Change in LGPL header does not apply to Apache SIS.
+Change in stop condition of the loop has been reverted.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20599:20970 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/GeophysicsCategoryList.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20599</th><th>Revision 20970</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ * This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> * GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> * http://geotools.org</span>
+<span class="add"> * (C) 2003-2006, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ * This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre>* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+* Lesser General Public License for more details.
+*
+<span class="del">* You should have received a copy of the GNU Lesser General Public</span>
+<span class="del">* License along with this library; if not, write to the Free Software</span>
+<span class="del">* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA</span>
+<span class="del">*</span>
+<span class="del">*</span>
+* This package contains documentation from OpenGIS specifications.
+* OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td>
+<td><pre>* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+* Lesser General Public License for more details.
+*
+* This package contains documentation from OpenGIS specifications.
+* OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td></tr>
+<tr><td><pre>private static int getFractionDigitCount(final Category[] categories) {
+ int ndigits = 0;
+ final double EPS = 1E-6;
+<span class="del"> for (int i=0; i<categories.length; i++) {</span>
+ final Category geophysics = categories[i].geophysics(true);
+ final Category samples = categories[i].geophysics(false);
+ final double ln = XMath.log10((geophysics.maximum - geophysics.minimum)/</pre></td>
+<td><pre>private static int getFractionDigitCount(final Category[] categories) {
+ int ndigits = 0;
+ final double EPS = 1E-6;
+<span class="add"> final int length=categories.length;</span>
+<span class="add"> for (int i=0; i<length; i++) {</span>
+ final Category geophysics = categories[i].geophysics(true);
+ final Category samples = categories[i].geophysics(false);
+ final double ln = XMath.log10((geophysics.maximum - geophysics.minimum)/</pre></td></tr>
+</table>
+ </div>
+ </body>
+</html>