You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/08 12:04:15 UTC
[GitHub] [apisix-ingress-controller] jwrookie commented on a change in pull request #907: docs: add pre-commit todo in the development guide
jwrookie commented on a change in pull request #907:
URL: https://github.com/apache/apisix-ingress-controller/pull/907#discussion_r821598224
##########
File path: docs/en/latest/development.md
##########
@@ -103,3 +103,18 @@ Something you need to pay attention to:
* configuring of `--kubeconfig`, if you are using Minikube, the file path should be `~/.kube/config`.
* configuring of `--default-apisix-cluster-admin-key`, if you have changed the admin key in Apache APISIX, also changing it here. If you have disabled the authentication in Apache APISIX, just removing this option.
+
+## Pre-commit todo
+
+When everything is ready, before submitting the code, please make sure that the license, code style, and document format are consistent with the project specification.
+
+We provide commands to implement it, just run the following commands:
+```shell
+make update-license
+make update-mdlint
+make update-gofmt
Review comment:
got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org