You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dengziming (via GitHub)" <gi...@apache.org> on 2023/12/12 09:20:07 UTC
[PR] [SPARK-45502][BUILD] Upgrade Kafka to 3.6.1 [spark]
dengziming opened a new pull request, #44312:
URL: https://github.com/apache/spark/pull/44312
### What changes were proposed in this pull request?
Upgrade Apache Kafka from 3.4.1 to 3.6.0
### Why are the changes needed?
- https://downloads.apache.org/kafka/3.6.1/RELEASE_NOTES.html
- https://downloads.apache.org/kafka/3.6.0/RELEASE_NOTES.html
- https://downloads.apache.org/kafka/3.5.0/RELEASE_NOTES.html
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
GitHub CI.
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #43348 from dengziming/kafka-3.6.0.
Authored-by: dengziming <de...@gmail.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45502][BUILD] Upgrade Kafka to 3.6.1 [spark]
Posted by "dengziming (via GitHub)" <gi...@apache.org>.
dengziming commented on code in PR #44312:
URL: https://github.com/apache/spark/pull/44312#discussion_r1425002107
##########
connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala:
##########
@@ -2691,7 +2691,9 @@ class KafkaSourceStressSuite extends KafkaSourceTest {
start + Random.nextInt(start + end - 1)
}
- test("stress test with multiple topics and partitions") {
+ override val brokerProps = Map("auto.create.topics.enable" -> "false")
Review Comment:
Add this property to reduce flakiness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45502][BUILD] Upgrade Kafka to 3.6.1 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44312: [SPARK-45502][BUILD] Upgrade Kafka to 3.6.1
URL: https://github.com/apache/spark/pull/44312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45502][BUILD] Upgrade Kafka to 3.6.1 [spark]
Posted by "dengziming (via GitHub)" <gi...@apache.org>.
dengziming commented on PR #44312:
URL: https://github.com/apache/spark/pull/44312#issuecomment-1853461219
@dongjoon-hyun It seems `SparkSessionE2ESuite` failed once and it's not related to this PR, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45502][BUILD] Upgrade Kafka to 3.6.1 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44312:
URL: https://github.com/apache/spark/pull/44312#discussion_r1425785574
##########
connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala:
##########
@@ -2691,7 +2691,9 @@ class KafkaSourceStressSuite extends KafkaSourceTest {
start + Random.nextInt(start + end - 1)
}
- test("stress test with multiple topics and partitions") {
+ override val brokerProps = Map("auto.create.topics.enable" -> "false")
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org