[GitHub] [airavata-django-portal] machristie commented on a change in pull request #55: Airavata 3321: adding read only view for Group Resource Profiles

[GitBox <gi...@apache.org>]

machristie commented on a change in pull request #55:
URL: https://github.com/apache/airavata-django-portal/pull/55#discussion_r599977135



##########
File path: django_airavata/apps/admin/static/django_airavata_admin/src/components/admin/group_resource_preferences/GroupComputeResourcePreference.vue
##########
@@ -141,8 +174,18 @@ export default {
     id: {
       type: String,
     },
+    readonly: {
+      type: Boolean,

Review comment:
       If the type can also be string, then you can have `type: [Boolean, String]` so both are accepted.

##########
File path: django_airavata/apps/admin/static/django_airavata_admin/src/components/admin/group_resource_preferences/GroupComputeResourcePreference.vue
##########
@@ -81,7 +86,31 @@
               Edit
               <i class="fa fa-edit" aria-hidden="true"></i>
             </router-link>
+            <router-link
+              class="action-link"
+              v-if="readonly"
+              :to="{
+                name: 'compute_preference',
+                params: {
+                  value: row.item,
+                  id: id,
+                  host_id: row.item.computeResourceId,
+                  readonly: false,

Review comment:
       Instead of 'false', this should be 'true' or just 'readonly'




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org