You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/10 21:50:03 UTC

[GitHub] [kafka] ableegoldman commented on a change in pull request #8833: KAFKA-9441: remove prepareClose() to simplify task management

ableegoldman commented on a change in pull request #8833:
URL: https://github.com/apache/kafka/pull/8833#discussion_r438427780



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##########
@@ -108,13 +107,20 @@ public void completeRestoration() {
     }
 
     @Override
-    public void prepareSuspend() {
-        log.trace("No-op prepareSuspend with state {}", state());
+    public void suspendDirty() {
+        log.trace("No-op suspend dirty with state {}", state());
+        if (state() == State.RUNNING) {

Review comment:
       Why not just make `suspend` a no-op if the task is RESTORING? That seems more in line with how we handle things elsewhere




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org