You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/05/19 10:40:18 UTC

[GitHub] [thrift] janosvitok commented on pull request #2149: Fix swift TSocketTransport on Mac

janosvitok commented on pull request #2149:
URL: https://github.com/apache/thrift/pull/2149#issuecomment-630737649


   This fixes https://issues.apache.org/jira/browse/THRIFT-5129. @taiyangc, you may want to edit PR description to mention this issue (and also rename it to THRIFT-5129: ...)
   
   Please check my comment in the issue (regarding UInt16(truncatingIfNeeded: port).bigEndian). It was needed for SocketServer for iOS app, but I didn't check why the client compiles without it...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org