[GitHub] [pinot] siddharthteotia commented on a diff in pull request #11575: Add metrics to export netty direct memory used and max

["siddharthteotia (via GitHub)" <gi...@apache.org>]

siddharthteotia commented on code in PR #11575:
URL: https://github.com/apache/pinot/pull/11575#discussion_r1323334725


##########
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java:
##########
@@ -151,7 +153,24 @@ private class ServerChannel {
 
     ServerChannel(ServerRoutingInstance serverRoutingInstance) {
       _serverRoutingInstance = serverRoutingInstance;
+      PooledByteBufAllocator bufAllocator = PooledByteBufAllocator.DEFAULT;
+      PooledByteBufAllocatorMetric metric = bufAllocator.metric();
+      _brokerMetrics.setOrUpdateGauge(BrokerGauge.NETTY_POOLED_USED_DIRECT_MEMORY.getGaugeName(),

Review Comment:
   So these will be emitted when a channel is established ? How do we capture the change in these memory metrics as a result of queries ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org