You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/22 12:16:20 UTC
[GitHub] [camel-kafka-connector] orpiske opened a new pull request #138: Test code fixes for the auto-generated connectors
orpiske opened a new pull request #138:
URL: https://github.com/apache/camel-kafka-connector/pull/138
This fixes a couple of errors in tests and adjust the code to work with the new
auto-generated connectors. It fixes most of the DelegatingClassLoader errors
although one still remain in one scenario: ElasticSearch Rest with Java 8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on issue #138: Test code fixes for the auto-generated connectors
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #138:
URL: https://github.com/apache/camel-kafka-connector/pull/138#issuecomment-617809137
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske commented on issue #138: Test code fixes for the auto-generated connectors
Posted by GitBox <gi...@apache.org>.
orpiske commented on issue #138:
URL: https://github.com/apache/camel-kafka-connector/pull/138#issuecomment-617819293
BTW: to remove the ElasticSearch error, we need to find a way to stop needing [this class](https://github.com/apache/camel-kafka-connector/blob/master/tests/src/test/java/org/apache/camel/kafkaconnector/sink/elasticsearch/transforms/ConnectRecordValueToMapTransformer.java). It does the transformation from the key/pair data format used in ElasticSearch to the record format used by the Kafka message. If we have a way to do this conversion automatically, then we can remove this class and [the dependency](https://github.com/apache/camel-kafka-connector/blob/master/tests/pom.xml#L49) on the `camel-elasticsearch-rest-kafka-connector`. This should do the trick of removing the last DelegationClassLoader error on the logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on issue #138: Test code fixes for the auto-generated connectors
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #138:
URL: https://github.com/apache/camel-kafka-connector/pull/138#issuecomment-617754787
@orpiske can you fix the codestyle?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske edited a comment on issue #138: Test code fixes for the auto-generated connectors
Posted by GitBox <gi...@apache.org>.
orpiske edited a comment on issue #138:
URL: https://github.com/apache/camel-kafka-connector/pull/138#issuecomment-617819293
~~BTW: to remove the ElasticSearch error, we need to find a way to stop requiring the [ConnectRecordValueToMapTransformer](https://github.com/apache/camel-kafka-connector/blob/master/tests/src/test/java/org/apache/camel/kafkaconnector/sink/elasticsearch/transforms/ConnectRecordValueToMapTransformer.java) class. It does the transformation from the key/pair data format used in ElasticSearch to the record format used by the Kafka message. If we have a way to do this conversion automatically, then we can remove this class and [the dependency](https://github.com/apache/camel-kafka-connector/blob/master/tests/pom.xml#L49) on the `camel-elasticsearch-rest-kafka-connector`. This should do the trick of removing the last DelegationClassLoader error on the logs.~~
Ahhh, no. @valdar gave me an idea that solves the problem without any of this. Just changing the elasticsearch provided dependency to the core one did the trick. Huge thanks for his idea!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on issue #138: Test code fixes for the auto-generated connectors
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #138:
URL: https://github.com/apache/camel-kafka-connector/pull/138#issuecomment-617814914
@valdar is it ok for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske commented on a change in pull request #138: Test code fixes for the auto-generated connectors
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #138:
URL: https://github.com/apache/camel-kafka-connector/pull/138#discussion_r412929845
##########
File path: tests/src/test/java/org/apache/camel/kafkaconnector/PluginPathHelper.java
##########
@@ -31,6 +31,14 @@
public final class PluginPathHelper {
private static final Logger LOG = LoggerFactory.getLogger(PluginPathHelper.class);
+ private static final String[] MODULES = {
+ "core", "connectors/camel-sjms2-kafka-connector", "connectors/camel-cql-kafka-connector", "" +
Review comment:
Broken formatting. I'll fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske commented on issue #138: Test code fixes for the auto-generated connectors
Posted by GitBox <gi...@apache.org>.
orpiske commented on issue #138:
URL: https://github.com/apache/camel-kafka-connector/pull/138#issuecomment-617757695
> @orpiske can you fix the codestyle?
Done! It should be fine now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske edited a comment on issue #138: Test code fixes for the auto-generated connectors
Posted by GitBox <gi...@apache.org>.
orpiske edited a comment on issue #138:
URL: https://github.com/apache/camel-kafka-connector/pull/138#issuecomment-617819293
BTW: to remove the ElasticSearch error, we need to find a way to stop requiring the [ConnectRecordValueToMapTransformer](https://github.com/apache/camel-kafka-connector/blob/master/tests/src/test/java/org/apache/camel/kafkaconnector/sink/elasticsearch/transforms/ConnectRecordValueToMapTransformer.java) class. It does the transformation from the key/pair data format used in ElasticSearch to the record format used by the Kafka message. If we have a way to do this conversion automatically, then we can remove this class and [the dependency](https://github.com/apache/camel-kafka-connector/blob/master/tests/pom.xml#L49) on the `camel-elasticsearch-rest-kafka-connector`. This should do the trick of removing the last DelegationClassLoader error on the logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on issue #138: Test code fixes for the auto-generated connectors
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #138:
URL: https://github.com/apache/camel-kafka-connector/pull/138#issuecomment-617758650
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske commented on issue #138: Test code fixes for the auto-generated connectors
Posted by GitBox <gi...@apache.org>.
orpiske commented on issue #138:
URL: https://github.com/apache/camel-kafka-connector/pull/138#issuecomment-617763520
@oscerd @valdar The code is failing because it is looking for the jars and we don't generate them here. I'm going to go back to the code and handle this scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org