You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/22 08:17:50 UTC
[GitHub] [dolphinscheduler-sdk-python] zhongjiajie opened a new pull request, #63: feat: Add stmdency handle @task decorate statement dependency
zhongjiajie opened a new pull request, #63:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/63
<!--Thanks for you contribute to Apache DolphinScheduler Python API, You can see more detail about contributing in https://github.com/apache/dolphinscheduler-sdk-python/DEVELOP.md .-->
## Brief Summary of The Change
<!--Please include `fixes: #XXXX(ISSUE_NUMBER)` to automatically close any corresponding issue when the pull request is merged. Alternatively if not fully closed you can say `related: #XXXX(ISSUE_NUMBER)`.-->
Before this, we can not handle statement dependency in task decorate, including global variable, other function call or import module
This patch we introduce stmdency to handle those issue and make it
## Pull Request checklist
I confirm that the following checklist has been completed.
- [x] Add/Change **test cases** for the changes.
- [x] Add/Change the related **documentation**, should also change `docs/source/config.rst` when you change file `default_config.yaml`.
- [x] (Optional) Add your change to `UPDATING.md` when it is an incompatible change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-sdk-python] codecov-commenter commented on pull request #63: feat: Add stmdency handle @task decorate statement dependency
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #63:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/63#issuecomment-1362545563
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/63?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#63](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/63?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a702e4d) into [main](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/commit/68d2670242ca9e47d4eb4b878334ab3fe972b262?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68d2670) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 90.94% 90.92% -0.02%
==========================================
Files 61 61
Lines 2209 2205 -4
==========================================
- Hits 2009 2005 -4
Misses 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `90.92% <100.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/pydolphinscheduler/tasks/python.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci90YXNrcy9weXRob24ucHk=) | `100.00% <ø> (ø)` | |
| [src/pydolphinscheduler/tasks/func\_wrap.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci90YXNrcy9mdW5jX3dyYXAucHk=) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-sdk-python] zhongjiajie merged pull request #63: feat: Add stmdency handle @task decorate statement dependency
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #63:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org