You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/30 18:48:56 UTC

[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #5769: [TE] add anomaly detection as a service - Phase 1

suvodeep-pyne commented on pull request #5769:
URL: https://github.com/apache/incubator-pinot/pull/5769#issuecomment-666597454


   Some thoughts:
   - It would be great if this PR can be split into smaller PRs: For example, the OnlineDataSource, TaskDriver changes and Resource changes seem like separate pieces. Correct me if I am wrong. That way it is just easier to review/understand/revert in case of some issue.
   - The `TaskDriver` runs (async) tasks. How does an online task work?
   - Also, is the resource piece directly interacting with the Task? The initial idea was to keep the anomaly detection as a backend piece. Are we calling 'backend' methods directly from Resource classes?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org