You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/17 08:25:58 UTC

[jira] [Commented] (NIFI-2905) ExecuteProcess should log error stream instead of ignoring it

    [ https://issues.apache.org/jira/browse/NIFI-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581582#comment-15581582 ] 

ASF GitHub Bot commented on NIFI-2905:
--------------------------------------

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/1143

    NIFI-2905: Log error stream of ExecuteProcess cmd

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-2905

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1143
    
----
commit 8edf84ab5384e85dfef8ac29d8c76ac55f052e75
Author: Koji Kawamura <ij...@apache.org>
Date:   2016-10-17T08:07:32Z

    NIFI-2905: Log error stream of ExecuteProcess cmd
    
    ExecuteProcess ignores error stream when Redirect Error Stream is
    false, this commit let it to be logged instead so that user can see it on
    bulletin.

----


> ExecuteProcess should log error stream instead of ignoring it
> -------------------------------------------------------------
>
>                 Key: NIFI-2905
>                 URL: https://issues.apache.org/jira/browse/NIFI-2905
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Koji Kawamura
>            Assignee: Koji Kawamura
>
> When a command executed by ExecuteProcess processor didn't work properly and emitted error messages to error stream, but the processor's configured with 'Redirect Error Stream' as 'false' (default), then the error messages are ignored, thus there's no way for user to see what went wrong.
> It can provide better UX by logging error stream as WARN level so that user can see it on bulletin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)