You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Scott Banachowski (JIRA)" <ji...@apache.org> on 2009/07/05 23:59:14 UTC

[jira] Commented: (AVRO-71) Followup - making some C++ object APIs more generic

    [ https://issues.apache.org/jira/browse/AVRO-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727369#action_12727369 ] 

Scott Banachowski commented on AVRO-71:
---------------------------------------

I made the patch again (the original patch was missing Reader.hh but shouldn't have been missing ValidatingReader.hh).  

When I made the patch this time, svn diff reports:

[liedriveglad-lm ~/avro-trunk] svn status -q
M      src/c++/test/unittest.cc
M      src/c++/test/testgen.cc
D      src/c++/impl/ValidatingSerializer.cc
D      src/c++/impl/ValidatingParser.cc
A  +   src/c++/impl/ValidatingReader.cc
M      src/c++/api/Parser.hh
D      src/c++/api/ValidatingParser.hh
A      src/c++/api/Reader.hh
M      src/c++/api/AvroParse.hh
A  +   src/c++/api/ValidatingReader.hh
M      src/c++/api/ValidatingWriter.hh
M      src/c++/Makefile

Hopefully, applying it should add Reader.hh and ValidatingReader.cc/hh and remove ValidatingParser.cc/hh and ValidatingSerializer.cc



> Followup - making some C++ object APIs more generic
> ---------------------------------------------------
>
>                 Key: AVRO-71
>                 URL: https://issues.apache.org/jira/browse/AVRO-71
>             Project: Avro
>          Issue Type: Improvement
>          Components: c++
>            Reporter: Scott Banachowski
>            Assignee: Scott Banachowski
>         Attachments: AVRO-71.patch
>
>
> This is a followup to issue AVRO-59.  In that change, a more generic version of Writer class was created to support templates.
> I now have done the same kind of refactor for the Reader version, to make Reader and Writer more symmetric.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.