You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/05/05 17:15:00 UTC
[jira] [Commented] (SOLR-16182) Close ZkClientClusterStateProvider in tests to avoid thread leak
[ https://issues.apache.org/jira/browse/SOLR-16182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532428#comment-17532428 ]
ASF subversion and git services commented on SOLR-16182:
--------------------------------------------------------
Commit 9ff7f428d0542190a0a450840505eac11d65e4d1 in solr's branch refs/heads/main from Kevin Risden
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=9ff7f428d05 ]
SOLR-16182: Close ZkClientClusterStateProvider in tests to avoid thread leak (#837)
> Close ZkClientClusterStateProvider in tests to avoid thread leak
> ----------------------------------------------------------------
>
> Key: SOLR-16182
> URL: https://issues.apache.org/jira/browse/SOLR-16182
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: Kevin Risden
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> https://lists.apache.org/list?builds@solr.apache.org:lte=1M:org.apache.solr.client.solrj.impl.CloudSolrClientBuilderTest.classMethod
> I personally haven't seen this fail locally, but looking at the test, ZkClientClusterStateProvider is created but never closed.
> [~magibney] pointed out in the PR this problem most likely exists elsewhere so will fix it up all at once:
> {code:java}
> > find solr -name '*.java' | xargs grep -l 'ZkClientClusterStateProvider\.from('
> solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientMultiConstructorTest.java
> solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientBuilderTest.java
> solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java
> solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientBuilderTest.java
> solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientTest.java
> solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientMultiConstructorTest.java
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org