[GitHub] [airflow] mik-laj commented on a change in pull request #20544: Use local definitions for k8s schema validation

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #20544:
URL: https://github.com/apache/airflow/pull/20544#discussion_r776159009



##########
File path: scripts/ci/pre_commit/pre_commit_vendor_k8s_json_schema.py
##########
@@ -0,0 +1,87 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import json
+
+import requests
+
+K8S_DEFINITIONS = (
+    "https://raw.githubusercontent.com/yannh/kubernetes-json-schema"
+    "/master/v1.22.0-standalone-strict/_definitions.json"
+)
+VALUES_SCHEMA_FILE = "chart/values.schema.json"
+
+
+with open(VALUES_SCHEMA_FILE) as f:
+    schema = json.load(f)
+
+refs = set()
+
+
+def find_refs(props: dict):
+    for value in props.values():
+        if "$ref" in value:
+            refs.add(value["$ref"])
+
+        if "items" in value:
+            if "$ref" in value["items"]:
+                refs.add(value["items"]["$ref"])
+
+        if "properties" in value:
+            find_refs(value["properties"])

Review comment:
       ```suggestion
   def find_refs(props: dict):
       for value in props.values():
           if "$ref" in value:
               yield value["$ref"]
   
           if "items" in value:
               if "$ref" in value["items"]:
                   yield value["items"]["$ref"]
   
           if "properties" in value:
               yield from find_refs(value["properties"])
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org