You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/05/23 19:53:46 UTC
Review Request 21871: Fixed the flaky SlaveRecovery MultipleFrameworks test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21871/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.
Bugs: MESOS-1365
https://issues.apache.org/jira/browse/MESOS-1365
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/slave_recovery_tests.cpp 6de811e
Diff: https://reviews.apache.org/r/21871/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 21871: Fixed the flaky SlaveRecovery MultipleFrameworks
test.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21871/#review43848
-----------------------------------------------------------
It looks reasonable to me, but I'm don't understand why this fixes the flakiness. Would you mind adding more information to the ticket?
- Dominic Hamon
On May 23, 2014, 10:53 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21871/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 10:53 a.m.)
>
>
> Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1365
> https://issues.apache.org/jira/browse/MESOS-1365
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 6de811e
>
> Diff: https://reviews.apache.org/r/21871/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 21871: Fixed the flaky SlaveRecovery MultipleFrameworks
test.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21871/#review43852
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On May 23, 2014, 11:10 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21871/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 11:10 a.m.)
>
>
> Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1365
> https://issues.apache.org/jira/browse/MESOS-1365
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
> Looks like the second offer, which is expected to be received by sched2, can be sent to sched1. If we don't decline the offer in sched1, sched2 may never receive the offer.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 6de811e
>
> Diff: https://reviews.apache.org/r/21871/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 21871: Fixed the flaky SlaveRecovery MultipleFrameworks
test.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21871/
-----------------------------------------------------------
(Updated May 23, 2014, 6:10 p.m.)
Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.
Changes
-------
Updated "description".
Bugs: MESOS-1365
https://issues.apache.org/jira/browse/MESOS-1365
Repository: mesos-git
Description (updated)
-------
See summary.
Looks like the second offer, which is expected to be received by sched2, can be sent to sched1. If we don't decline the offer in sched1, sched2 may never receive the offer.
Diffs
-----
src/tests/slave_recovery_tests.cpp 6de811e
Diff: https://reviews.apache.org/r/21871/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 21871: Fixed the flaky SlaveRecovery MultipleFrameworks
test.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21871/#review43847
-----------------------------------------------------------
Would you mind explaining what the bug and the fix here is? It's not obvious to me.
- Vinod Kone
On May 23, 2014, 5:53 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21871/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 5:53 p.m.)
>
>
> Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1365
> https://issues.apache.org/jira/browse/MESOS-1365
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 6de811e
>
> Diff: https://reviews.apache.org/r/21871/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>