[jira] [Commented] (HIVE-4576) templeton.hive.properties does not allow values with commas

["Sushanth Sowmyan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990118#comment-13990118 ] 

Sushanth Sowmyan commented on HIVE-4576:
----------------------------------------

After discussion on Eugene on whether this was a bugfix or a new feature to see if it should be included in 0.13.1, my understanding is now that this is a bugfix for cases where hive.metastore.uris can be a comma-separated value, and this bug breaks being able to use webhcat on those warehouses. Thus, I feel that a tag of "minor" is inappropriate, and am bumping it up.

> templeton.hive.properties does not allow values with commas
> -----------------------------------------------------------
>
>                 Key: HIVE-4576
>                 URL: https://issues.apache.org/jira/browse/HIVE-4576
>             Project: Hive
>          Issue Type: Bug
>          Components: WebHCat
>    Affects Versions: 0.5.0
>            Reporter: Vitaliy Fuks
>            Assignee: Eugene Koifman
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: HIVE-4576.2.patch, HIVE-4576.patch
>
>
> templeton.hive.properties accepts a comma-separated list of key=value property pairs that will be passed to Hive.
> However, this makes it impossible to use any "value" that itself has a comma in it.
> For example:
> {code:xml}<property>
>   <name>templeton.hive.properties</name>
>   <value>hive.metastore.sasl.enabled=false,hive.metastore.uris=thrift://foo1.example.com:9083,foo2.example.com:9083</value>
> </property>{code}
> {noformat}templeton: starting [/usr/bin/hive, --service, cli, --hiveconf, hive.metastore.sasl.enabled=false, --hiveconf, hive.metastore.uris=thrift://foo1.example.com:9083, --hiveconf, foo2.example.com:9083 etc..{noformat}
> because the value is parsed using standard org.apache.hadoop.conf.Configuration.getStrings() call which simply splits on commas from here:
> {code:java}for (String prop : appConf.getStrings(AppConfig.HIVE_PROPS_NAME)){code}
> This is problematic for any hive property that itself has multiple values, such as hive.metastore.uris above or hive.aux.jars.path.
> There should be some way to "escape" commas or a different delimiter should be used.



--
This message was sent by Atlassian JIRA
(v6.2#6252)