[GitHub] [spark] squito commented on a change in pull request #23393: [SPARK-26288][CORE]add initRegisteredExecutorsDB

[GitBox <gi...@apache.org>]

squito commented on a change in pull request #23393: [SPARK-26288][CORE]add initRegisteredExecutorsDB
URL: https://github.com/apache/spark/pull/23393#discussion_r262246651
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
 ##########
 @@ -467,6 +467,15 @@ private[deploy] class Worker(
         }.foreach { dir =>
           logInfo(s"Removing directory: ${dir.getPath}")
           Utils.deleteRecursively(dir)
+
+          // Remove some registeredExecutors information of DB in external shuffle service when
+          // #spark.shuffle.service.db.enabled=true, the one which comes to mind is, what happens
+          // if an application is stopped while the external shuffle service is down?
+          // So then it'll leave an entry in the DB and the entry should be removed.
+          if (conf.get(config.SHUFFLE_SERVICE_DB_ENABLED) &&
+            conf.get(config.SHUFFLE_SERVICE_ENABLED)) {
 
 Review comment:
   nit: double indent this line (4 spaces)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org