You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/13 02:51:25 UTC

[GitHub] [helix] jiajunwang opened a new pull request #1263: Extend the task future tracking to a Map instead of a single object.

jiajunwang opened a new pull request #1263:
URL: https://github.com/apache/helix/pull/1263


   ### Issues
   
   - [ ] My PR addresses the following Helix issues and references them in the PR description:
   
   Fixes #1262 
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   Since the ZkBucketDataAccessor is used to access multiple paths, a single task future track is not enough. This change uses a map with the path as the key to track tasks for different paths.
   Also, enhance the test case to cover the scenario of multiple paths being accessed in a short period.
   
   ### Tests
   
   - [X] The following tests are written for this issue:
   
   TestZkBucketDataAccessor test method modified to test with multiple paths.
   
   - [ ] The following is the result of the "mvn test" command on the appropriate module:
   
   Running...
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang commented on pull request #1263: Extend the task future tracking to a Map instead of a single object.

Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1263:
URL: https://github.com/apache/helix/pull/1263#issuecomment-673673876


   > Looks good to me. Although I'm curious to know: if a path is updated on a frequent interval which is less than the TTL, its stale versions will steadily grow in size. Is that a case we would worry about?
   
   The TTL design is to prevent GC a node that might being accessed by other threads/nodes. If update is frequent, then we may have multiple version during the TTL window. But they will eventually be cleaned up.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang commented on pull request #1263: Extend the task future tracking to a Map instead of a single object.

Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1263:
URL: https://github.com/apache/helix/pull/1263#issuecomment-673673998


   This PR is ready to be merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang merged pull request #1263: Extend the task future tracking to a Map instead of a single object.

Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1263:
URL: https://github.com/apache/helix/pull/1263


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org