You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/10 07:12:16 UTC
[GitHub] [spark] yaooqinn opened a new pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
yaooqinn opened a new pull request #29708:
URL: https://github.com/apache/spark/pull/29708
### What changes were proposed in this pull request?
In this PR, we add a checker for STRING form interval value ahead for parsing multiple units intervals and fail directly if the interval value contains alphabets to prevent correctness issues like `interval '1 day 2' day`=`3 days`.
### Why are the changes needed?
fix correctness issue
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
yes, in spark 3.0 `interval '1 day 2' day`=`3 days` but now we fail with ParseException
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
add a test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690076217
**[Test build #128500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128500/testReport)** for PR 29708 at commit [`a9294a1`](https://github.com/apache/spark/commit/a9294a1b701ce39578715362396c2fb3138a03a2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29708:
URL: https://github.com/apache/spark/pull/29708
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29708:
URL: https://github.com/apache/spark/pull/29708#discussion_r486151830
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2132,7 +2134,12 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
val kvs = units.indices.map { i =>
val u = units(i).getText
val v = if (values(i).STRING() != null) {
- string(values(i).STRING())
+ val value = string(values(i).STRING()).trim
+ if (!intervalValStrPattern.matcher(value).matches()) {
Review comment:
And we should add comments to explain why we need the check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690084112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29708:
URL: https://github.com/apache/spark/pull/29708#discussion_r486150079
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2132,7 +2134,12 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
val kvs = units.indices.map { i =>
val u = units(i).getText
val v = if (values(i).STRING() != null) {
- string(values(i).STRING())
+ val value = string(values(i).STRING()).trim
+ if (!intervalValStrPattern.matcher(value).matches()) {
Review comment:
how about `!value.forall { c => c == '.' || Character.isDigit(c)}`? We don't have to use regex.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690324661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690042597
**[Test build #128497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128497/testReport)** for PR 29708 at commit [`480fe6d`](https://github.com/apache/spark/commit/480fe6d21a1127668db157269edd0bbdadd8f5a4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690076217
**[Test build #128500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128500/testReport)** for PR 29708 at commit [`a9294a1`](https://github.com/apache/spark/commit/a9294a1b701ce39578715362396c2fb3138a03a2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690083590
**[Test build #128501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128501/testReport)** for PR 29708 at commit [`7e98555`](https://github.com/apache/spark/commit/7e98555e073f16fdcb255edfd759c7470efb63e5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690084112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690076746
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690042597
**[Test build #128497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128497/testReport)** for PR 29708 at commit [`480fe6d`](https://github.com/apache/spark/commit/480fe6d21a1127668db157269edd0bbdadd8f5a4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690069124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690076746
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690180926
@yaooqinn can you open a new PR for 3.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690219308
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690083590
**[Test build #128501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128501/testReport)** for PR 29708 at commit [`7e98555`](https://github.com/apache/spark/commit/7e98555e073f16fdcb255edfd759c7470efb63e5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29708:
URL: https://github.com/apache/spark/pull/29708#discussion_r486151611
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2132,7 +2134,12 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
val kvs = units.indices.map { i =>
val u = units(i).getText
val v = if (values(i).STRING() != null) {
- string(values(i).STRING())
+ val value = string(values(i).STRING()).trim
+ if (!intervalValStrPattern.matcher(value).matches()) {
Review comment:
ok maybe the first version is better, as we basically just want to avoid the `value` string to contain unit. `value.exists(Character.isLetter)` should be good enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29708:
URL: https://github.com/apache/spark/pull/29708#discussion_r486134971
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2120,6 +2120,8 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
}
}
+ private final val alphabet = "[a-zA-Z]".r.pattern
Review comment:
instead of checking the invalid ones, how about we make sure the value only has digits and dots?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690322562
**[Test build #128497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128497/testReport)** for PR 29708 at commit [`480fe6d`](https://github.com/apache/spark/commit/480fe6d21a1127668db157269edd0bbdadd8f5a4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #29708:
URL: https://github.com/apache/spark/pull/29708#discussion_r486146569
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2120,6 +2120,8 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
}
}
+ private final val alphabet = "[a-zA-Z]".r.pattern
Review comment:
OK updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690324661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29708:
URL: https://github.com/apache/spark/pull/29708#discussion_r486150079
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2132,7 +2134,12 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
val kvs = units.indices.map { i =>
val u = units(i).getText
val v = if (values(i).STRING() != null) {
- string(values(i).STRING())
+ val value = string(values(i).STRING()).trim
+ if (!intervalValStrPattern.matcher(value).matches()) {
Review comment:
how about `!value.forall { c => c == '.' || c == "+" || c == "-" || Character.isDigit(c)}`? We don't have to use regex.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690218966
**[Test build #128501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128501/testReport)** for PR 29708 at commit [`7e98555`](https://github.com/apache/spark/commit/7e98555e073f16fdcb255edfd759c7470efb63e5).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690349930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690072464
**[Test build #128499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128499/testReport)** for PR 29708 at commit [`aa9e9bf`](https://github.com/apache/spark/commit/aa9e9bf2b67fbe658a33dff2add49ea429519be0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690179942
github action passed, I'm merging it to master, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690069124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690343614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690343614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690340237
**[Test build #128499 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128499/testReport)** for PR 29708 at commit [`aa9e9bf`](https://github.com/apache/spark/commit/aa9e9bf2b67fbe658a33dff2add49ea429519be0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690072464
**[Test build #128499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128499/testReport)** for PR 29708 at commit [`aa9e9bf`](https://github.com/apache/spark/commit/aa9e9bf2b67fbe658a33dff2add49ea429519be0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690043877
cc @cloud-fan @maropu @HyukjinKwon and thanks very much for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690349930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690219308
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690039554
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690039554
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690346074
**[Test build #128500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128500/testReport)** for PR 29708 at commit [`a9294a1`](https://github.com/apache/spark/commit/a9294a1b701ce39578715362396c2fb3138a03a2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29708: [SPARK-32840][SQL] Invalid interval value can happen to be just adhesive with the unit
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29708:
URL: https://github.com/apache/spark/pull/29708#issuecomment-690219314
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128501/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org