You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/08 02:40:06 UTC
[GitHub] [flink] LongWangXX opened a new pull request #16417: FLINK-22969
LongWangXX opened a new pull request #16417:
URL: https://github.com/apache/flink/pull/16417
## What is the purpose of the change
Fix FLINK-22969, verify that topic is not null and not an empty string when creating KafkaSourceFunction and KafkaSinkFunction。
## Brief change log
The KafkaTopicsDescriptor object will be created in the constructor of the FlinkKafkaConsumerBase class, and I added a check topic in the constructor of KafkaTopicsDescriptor to see if the topic is empty。
in FlinkKafkaProducer.FlinkKafkaProducer(
String defaultTopic,
KeyedSerializationSchema<IN> keyedSchema,
FlinkKafkaPartitioner<IN> customPartitioner,
KafkaSerializationSchema<IN> kafkaSchema,
Properties producerConfig,
FlinkKafkaProducer.Semantic semantic,
The int kafkaProducersPoolSize) method is added to check whether the defaultTopic is empty, because all FlinkKafkaProducer constructors will call this constructor.
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no )
- The runtime per-record code paths (performance sensitive): ( no )
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
- The S3 file system connector: ( no)
## Documentation
Does this pull request introduce a new feature? ( no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877737608
@flinkbot run travis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876306247
@luoyuxia Thank you for your hard review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
}, {
"hash" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159",
"triggerID" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"triggerType" : "PUSH"
}, {
"hash" : "dfc073dc704129e4a99002494765dff0948b02a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfc073dc704129e4a99002494765dff0948b02a2",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfc073dc704129e4a99002494765dff0948b02a2 UNKNOWN
* 2534af9765d415628a98e8c56d9a938cb075d27b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a change in pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on a change in pull request #16417:
URL: https://github.com/apache/flink/pull/16417#discussion_r666013983
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -647,8 +646,10 @@ private FlinkKafkaProducer(
new FlinkKafkaProducer.TransactionStateSerializer(),
new FlinkKafkaProducer.ContextStateSerializer());
+ checkArgument(
+ !org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly(defaultTopic),
+ "defaultTopic cannot be null or empty string");
this.defaultTopicId = checkNotNull(defaultTopic, "defaultTopic is null");
Review comment:
As we have checked the defaultTopicId is null or not before by the statement checkArgument(xxx), here we don't need to checknotNull again.
we can just assign this.defaultTopicId without any check.
this.defaultTopicId = defaultTopic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
}, {
"hash" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159",
"triggerID" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"triggerType" : "PUSH"
}, {
"hash" : "dfc073dc704129e4a99002494765dff0948b02a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfc073dc704129e4a99002494765dff0948b02a2",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159)
* dfc073dc704129e4a99002494765dff0948b02a2 UNKNOWN
* 2534af9765d415628a98e8c56d9a938cb075d27b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877737225
@RocMarshal Okay thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
}, {
"hash" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159",
"triggerID" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"triggerType" : "PUSH"
}, {
"hash" : "dfc073dc704129e4a99002494765dff0948b02a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfc073dc704129e4a99002494765dff0948b02a2",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738466",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* dfc073dc704129e4a99002494765dff0948b02a2 UNKNOWN
* 2534af9765d415628a98e8c56d9a938cb075d27b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a change in pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on a change in pull request #16417:
URL: https://github.com/apache/flink/pull/16417#discussion_r665846147
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicsDescriptor.java
##########
@@ -41,17 +42,25 @@
private final Pattern topicPattern;
public KafkaTopicsDescriptor(
- @Nullable List<String> fixedTopics, @Nullable Pattern topicPattern) {
+ @Nullable List<String> fixedTopics, @Nullable Pattern topicPattern) {
Review comment:
The code format is not right, have you followed the guide
https://ci.apache.org/projects/flink/flink-docs-master/docs/flinkdev/ide_setup/#code-formatting ?
We need a consistent code format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX closed pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX closed pull request #16417:
URL: https://github.com/apache/flink/pull/16417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8e280ccc9d30446c0280ecf8b8028b2cd25206f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
}, {
"hash" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159",
"triggerID" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"triggerType" : "PUSH"
}, {
"hash" : "dfc073dc704129e4a99002494765dff0948b02a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfc073dc704129e4a99002494765dff0948b02a2",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738466",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "68e33105ba388305297e052376e8ce8e0a39cbaf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20274",
"triggerID" : "68e33105ba388305297e052376e8ce8e0a39cbaf",
"triggerType" : "PUSH"
}, {
"hash" : "b0125ab177e83aff91219dfb2215e47489d897c5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b0125ab177e83aff91219dfb2215e47489d897c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfc073dc704129e4a99002494765dff0948b02a2 UNKNOWN
* 68e33105ba388305297e052376e8ce8e0a39cbaf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20274)
* b0125ab177e83aff91219dfb2215e47489d897c5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876076375
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b0125ab177e83aff91219dfb2215e47489d897c5 (Thu Sep 23 18:02:41 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-22969).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877764089
@LongWangXX I notice that there was anything changed after my first comments.
Maybe you should run `mvn spotless:apply` in flink root directory to fix the checkstyle in the parts which you changed.
And commit the changes to activate the CI-robot automicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
}, {
"hash" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159",
"triggerID" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"triggerType" : "PUSH"
}, {
"hash" : "dfc073dc704129e4a99002494765dff0948b02a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfc073dc704129e4a99002494765dff0948b02a2",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738466",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "68e33105ba388305297e052376e8ce8e0a39cbaf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20274",
"triggerID" : "68e33105ba388305297e052376e8ce8e0a39cbaf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfc073dc704129e4a99002494765dff0948b02a2 UNKNOWN
* 68e33105ba388305297e052376e8ce8e0a39cbaf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20274)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876141971
@luoyuxia Thank you for your review, thank you for your hard work. I'm very sorry, there are so many questions, let me fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX removed a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX removed a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877737608
@flinkbot run travis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876861105
@luoyuxia Hello, can you help me merge the code into the master branch? Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a change in pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on a change in pull request #16417:
URL: https://github.com/apache/flink/pull/16417#discussion_r666020950
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicsDescriptor.java
##########
@@ -51,8 +50,19 @@ public KafkaTopicsDescriptor(
checkArgument(
!fixedTopics.isEmpty(),
"If subscribing to a fixed topics list, the supplied list cannot be empty.");
+ fixedTopics.forEach(
+ topic -> {
+ checkArgument(
+ !org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly(topic),
Review comment:
Sorry for the misleading, we don't need to specific org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly, we can just import org.apache.flink.util.StringUtils and use StringUtils.isNullOrWhitespaceOnly here.
The reason we need to specific org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly in class FlinkKafkaProducer.java is that we also use org.apache.commons.lang3.StringUtils in FlinkKafkaProducer.java .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877765766
@RocMarshal I just ran issuesmvn spotless:apply in the Flink root directory and submitted it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a change in pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on a change in pull request #16417:
URL: https://github.com/apache/flink/pull/16417#discussion_r666013983
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -647,8 +646,10 @@ private FlinkKafkaProducer(
new FlinkKafkaProducer.TransactionStateSerializer(),
new FlinkKafkaProducer.ContextStateSerializer());
+ checkArgument(
+ !org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly(defaultTopic),
+ "defaultTopic cannot be null or empty string");
this.defaultTopicId = checkNotNull(defaultTopic, "defaultTopic is null");
Review comment:
As we have check the defaultTopicId is null or not, here we don't need to checknotNull again.
we can just assign this.defaultTopicId without any check.
this.defaultTopicId = defaultTopic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX commented on a change in pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX commented on a change in pull request #16417:
URL: https://github.com/apache/flink/pull/16417#discussion_r667576921
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -647,8 +648,10 @@ private FlinkKafkaProducer(
new FlinkKafkaProducer.TransactionStateSerializer(),
new FlinkKafkaProducer.ContextStateSerializer());
- this.defaultTopicId = checkNotNull(defaultTopic, "defaultTopic is null");
-
+ checkArgument(
+ !org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly(defaultTopic),
Review comment:
Thank you for your suggestion, it's good, I modified it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877924725
@LongWangXX Hi, I notice that the implements of `org.apache.flink.util.StringUtils#isNullOrWhitespaceOnly` is samilar to the implements of `org.apache.commons.lang3.StringUtils#isBlank`. IMO, We just need to keep consistent StringUtils calling `StringUtils#isBlank` without package prefix instead `org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly(defaultTopic)` and keep the `StringUtils` reference located from the same package. Thanks for your attention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a change in pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on a change in pull request #16417:
URL: https://github.com/apache/flink/pull/16417#discussion_r666020950
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicsDescriptor.java
##########
@@ -51,8 +50,19 @@ public KafkaTopicsDescriptor(
checkArgument(
!fixedTopics.isEmpty(),
"If subscribing to a fixed topics list, the supplied list cannot be empty.");
+ fixedTopics.forEach(
+ topic -> {
+ checkArgument(
+ !org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly(topic),
Review comment:
Sorry for the misleading, we don't need to specific org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly, we can just import org.apache.flink.util.StringUtils and use StringUtils.isNullOrWhitespaceOnly here.
The reason we need to specific org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly in class FlinkKafkaProducer.java is that we have imported org.apache.commons.lang3.StringUtils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
}, {
"hash" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159",
"triggerID" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"triggerType" : "PUSH"
}, {
"hash" : "dfc073dc704129e4a99002494765dff0948b02a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfc073dc704129e4a99002494765dff0948b02a2",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738466",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "68e33105ba388305297e052376e8ce8e0a39cbaf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68e33105ba388305297e052376e8ce8e0a39cbaf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfc073dc704129e4a99002494765dff0948b02a2 UNKNOWN
* 2534af9765d415628a98e8c56d9a938cb075d27b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166)
* 68e33105ba388305297e052376e8ce8e0a39cbaf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
}, {
"hash" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159",
"triggerID" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"triggerType" : "PUSH"
}, {
"hash" : "dfc073dc704129e4a99002494765dff0948b02a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfc073dc704129e4a99002494765dff0948b02a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159)
* dfc073dc704129e4a99002494765dff0948b02a2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877764089
@LongWangXX I notice that there was nothing changed after my first comments.
Maybe you should run `mvn spotless:apply` in flink root directory to fix the checkstyle in the parts which you changed.
And commit the changes to activate the CI-robot automicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8e280ccc9d30446c0280ecf8b8028b2cd25206f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
}, {
"hash" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159",
"triggerID" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"triggerType" : "PUSH"
}, {
"hash" : "dfc073dc704129e4a99002494765dff0948b02a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfc073dc704129e4a99002494765dff0948b02a2",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738466",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "68e33105ba388305297e052376e8ce8e0a39cbaf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20274",
"triggerID" : "68e33105ba388305297e052376e8ce8e0a39cbaf",
"triggerType" : "PUSH"
}, {
"hash" : "b0125ab177e83aff91219dfb2215e47489d897c5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20290",
"triggerID" : "b0125ab177e83aff91219dfb2215e47489d897c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfc073dc704129e4a99002494765dff0948b02a2 UNKNOWN
* 68e33105ba388305297e052376e8ce8e0a39cbaf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20274)
* b0125ab177e83aff91219dfb2215e47489d897c5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20290)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877924725
@LongWangXX Hi, I notice that the implements of `org.apache.flink.util.StringUtils#isNullOrWhitespaceOnly` is samilar to the implements of `org.apache.commons.lang3.StringUtils#isBlank`. IMO, We just need to keep consistent StringUtils calling `StringUtils#XXX` without package prefix instead `org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly(defaultTopic)` and keep the `StringUtils` reference located from the same package. Thanks for your attention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
}, {
"hash" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8e280ccc9d30446c0280ecf8b8028b2cd25206f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135)
* fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
}, {
"hash" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159",
"triggerID" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"triggerType" : "PUSH"
}, {
"hash" : "dfc073dc704129e4a99002494765dff0948b02a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfc073dc704129e4a99002494765dff0948b02a2",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159)
* dfc073dc704129e4a99002494765dff0948b02a2 UNKNOWN
* 2534af9765d415628a98e8c56d9a938cb075d27b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877736826
@LongWangXX Hi, Thank you for your contribution. And maybe you should fix the checkstyle and errors shown in the CI build log before running CI robot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877738112
@flinkbot run travis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876076375
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e8e280ccc9d30446c0280ecf8b8028b2cd25206f (Thu Jul 08 02:42:30 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-22969).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a change in pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #16417:
URL: https://github.com/apache/flink/pull/16417#discussion_r667566342
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -647,8 +648,10 @@ private FlinkKafkaProducer(
new FlinkKafkaProducer.TransactionStateSerializer(),
new FlinkKafkaProducer.ContextStateSerializer());
- this.defaultTopicId = checkNotNull(defaultTopic, "defaultTopic is null");
-
+ checkArgument(
+ !org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly(defaultTopic),
Review comment:
What about `StringUtils#isNotBlank` of package `org.apache.commons.lang3` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a change in pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on a change in pull request #16417:
URL: https://github.com/apache/flink/pull/16417#discussion_r666011934
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -88,8 +88,7 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong;
-import static org.apache.flink.util.Preconditions.checkNotNull;
-import static org.apache.flink.util.Preconditions.checkState;
+import static org.apache.flink.util.Preconditions.*;
Review comment:
we should use such import statment with '.*', otherwise it will be fail to pass compile.
Just keep use
import static org.apache.flink.util.Preconditions.checkNotNull;
import static org.apache.flink.util.Preconditions.checkState;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a change in pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on a change in pull request #16417:
URL: https://github.com/apache/flink/pull/16417#discussion_r666018479
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicsDescriptor.java
##########
@@ -41,17 +42,25 @@
private final Pattern topicPattern;
public KafkaTopicsDescriptor(
- @Nullable List<String> fixedTopics, @Nullable Pattern topicPattern) {
+ @Nullable List<String> fixedTopics, @Nullable Pattern topicPattern) {
checkArgument(
- (fixedTopics != null && topicPattern == null)
- || (fixedTopics == null && topicPattern != null),
- "Exactly one of either fixedTopics or topicPattern must be specified.");
+ (fixedTopics != null && topicPattern == null)
+ || (fixedTopics == null && topicPattern != null),
+ "Exactly one of either fixedTopics or topicPattern must be specified.");
if (fixedTopics != null) {
checkArgument(
- !fixedTopics.isEmpty(),
- "If subscribing to a fixed topics list, the supplied list cannot be empty.");
+ !fixedTopics.isEmpty(),
+ "If subscribing to a fixed topics list, the supplied list cannot be empty.");
+ fixedTopics.forEach(topic -> {
+ checkNotNull(topic, "An null topic exists in the subscribed topics list.");
+ checkArgument(!"".equals(topic), "An empty topic exists in the subscribed topics list.");
+ });
}
+ if (topicPattern != null) {
Review comment:
It's no need to check topicPattern is empty or not, it's legal if topicPattern is empty.
we can just delete the statement
if (topicPattern != null) {
...
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
}, {
"hash" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159",
"triggerID" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"triggerType" : "PUSH"
}, {
"hash" : "dfc073dc704129e4a99002494765dff0948b02a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfc073dc704129e4a99002494765dff0948b02a2",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "877738466",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* dfc073dc704129e4a99002494765dff0948b02a2 UNKNOWN
* 0000 Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
}, {
"hash" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159",
"triggerID" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"triggerType" : "PUSH"
}, {
"hash" : "dfc073dc704129e4a99002494765dff0948b02a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfc073dc704129e4a99002494765dff0948b02a2",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738466",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "68e33105ba388305297e052376e8ce8e0a39cbaf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20274",
"triggerID" : "68e33105ba388305297e052376e8ce8e0a39cbaf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfc073dc704129e4a99002494765dff0948b02a2 UNKNOWN
* 2534af9765d415628a98e8c56d9a938cb075d27b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166)
* 68e33105ba388305297e052376e8ce8e0a39cbaf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20274)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877737240
@flinkbot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a change in pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on a change in pull request #16417:
URL: https://github.com/apache/flink/pull/16417#discussion_r666011934
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -88,8 +88,7 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong;
-import static org.apache.flink.util.Preconditions.checkNotNull;
-import static org.apache.flink.util.Preconditions.checkState;
+import static org.apache.flink.util.Preconditions.*;
Review comment:
we shouldn't use such import statment with '.*', otherwise it will be fail to pass style check.
Just keep use
import static org.apache.flink.util.Preconditions.checkNotNull;
import static org.apache.flink.util.Preconditions.checkState;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-876088562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20135",
"triggerID" : "e8e280ccc9d30446c0280ecf8b8028b2cd25206f",
"triggerType" : "PUSH"
}, {
"hash" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20159",
"triggerID" : "fdbadc860a18a4cc0a9ed7c2cd27a2451d1f6858",
"triggerType" : "PUSH"
}, {
"hash" : "dfc073dc704129e4a99002494765dff0948b02a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfc073dc704129e4a99002494765dff0948b02a2",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"triggerType" : "PUSH"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "2534af9765d415628a98e8c56d9a938cb075d27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20166",
"triggerID" : "877738466",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877737618",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "877738112",
"triggerType" : "MANUAL"
}, {
"hash" : "68e33105ba388305297e052376e8ce8e0a39cbaf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20274",
"triggerID" : "68e33105ba388305297e052376e8ce8e0a39cbaf",
"triggerType" : "PUSH"
}, {
"hash" : "b0125ab177e83aff91219dfb2215e47489d897c5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20290",
"triggerID" : "b0125ab177e83aff91219dfb2215e47489d897c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfc073dc704129e4a99002494765dff0948b02a2 UNKNOWN
* b0125ab177e83aff91219dfb2215e47489d897c5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20290)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877738466
> @LongWangXX Hi, Thank you for your contribution. And maybe you should fix the checkstyle and errors shown in the CI build log before running CI robot.
I used @flinkbot run azure but the robot does not seem to re-run the detection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX removed a comment on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX removed a comment on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877737240
@flinkbot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a change in pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on a change in pull request #16417:
URL: https://github.com/apache/flink/pull/16417#discussion_r665844774
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicsDescriptor.java
##########
@@ -41,17 +42,25 @@
private final Pattern topicPattern;
public KafkaTopicsDescriptor(
- @Nullable List<String> fixedTopics, @Nullable Pattern topicPattern) {
+ @Nullable List<String> fixedTopics, @Nullable Pattern topicPattern) {
checkArgument(
- (fixedTopics != null && topicPattern == null)
- || (fixedTopics == null && topicPattern != null),
- "Exactly one of either fixedTopics or topicPattern must be specified.");
+ (fixedTopics != null && topicPattern == null)
+ || (fixedTopics == null && topicPattern != null),
+ "Exactly one of either fixedTopics or topicPattern must be specified.");
if (fixedTopics != null) {
checkArgument(
- !fixedTopics.isEmpty(),
- "If subscribing to a fixed topics list, the supplied list cannot be empty.");
+ !fixedTopics.isEmpty(),
+ "If subscribing to a fixed topics list, the supplied list cannot be empty.");
+ fixedTopics.forEach(topic -> {
+ checkNotNull(topic, "An null topic exists in the subscribed topics list.");
+ checkArgument(!"".equals(topic), "An empty topic exists in the subscribed topics list.");
+ });
}
+ if (topicPattern != null) {
Review comment:
I think it's fine if topicPatten is empty.
So we don't need to check whether topicPattern is empty or not.
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -647,8 +646,8 @@ private FlinkKafkaProducer(
new FlinkKafkaProducer.TransactionStateSerializer(),
new FlinkKafkaProducer.ContextStateSerializer());
+ checkArgument(!"".equals(defaultTopic),"defaultTopic is empty");
Review comment:
maybe we can use
'
checkArgument(
!org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly(defaultTopic), "defaultTopic cannot be null or empty string");
'
to check
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicsDescriptor.java
##########
@@ -85,7 +94,7 @@ public boolean isMatchingTopic(String topic) {
@Override
public String toString() {
return (fixedTopics == null)
- ? "Topic Regex Pattern (" + topicPattern.pattern() + ")"
- : "Fixed Topics (" + fixedTopics + ")";
+ ? "Topic Regex Pattern (" + topicPattern.pattern() + ")"
Review comment:
The code format is not right.
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicsDescriptor.java
##########
@@ -41,17 +42,25 @@
private final Pattern topicPattern;
public KafkaTopicsDescriptor(
- @Nullable List<String> fixedTopics, @Nullable Pattern topicPattern) {
+ @Nullable List<String> fixedTopics, @Nullable Pattern topicPattern) {
checkArgument(
- (fixedTopics != null && topicPattern == null)
- || (fixedTopics == null && topicPattern != null),
- "Exactly one of either fixedTopics or topicPattern must be specified.");
+ (fixedTopics != null && topicPattern == null)
+ || (fixedTopics == null && topicPattern != null),
+ "Exactly one of either fixedTopics or topicPattern must be specified.");
if (fixedTopics != null) {
checkArgument(
- !fixedTopics.isEmpty(),
- "If subscribing to a fixed topics list, the supplied list cannot be empty.");
+ !fixedTopics.isEmpty(),
+ "If subscribing to a fixed topics list, the supplied list cannot be empty.");
+ fixedTopics.forEach(topic -> {
+ checkNotNull(topic, "An null topic exists in the subscribed topics list.");
Review comment:
Here, we can use
'
checkArgument(
!org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly(topic), "topic in the subscribed topics list cannot be null or empty string.");
'
to check
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicsDescriptor.java
##########
@@ -41,17 +42,25 @@
private final Pattern topicPattern;
public KafkaTopicsDescriptor(
- @Nullable List<String> fixedTopics, @Nullable Pattern topicPattern) {
+ @Nullable List<String> fixedTopics, @Nullable Pattern topicPattern) {
Review comment:
The code format is not right, have you follow the guide
https://ci.apache.org/projects/flink/flink-docs-master/docs/flinkdev/ide_setup/#code-formatting ?
We need a consistent code format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a change in pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on a change in pull request #16417:
URL: https://github.com/apache/flink/pull/16417#discussion_r666018479
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicsDescriptor.java
##########
@@ -41,17 +42,25 @@
private final Pattern topicPattern;
public KafkaTopicsDescriptor(
- @Nullable List<String> fixedTopics, @Nullable Pattern topicPattern) {
+ @Nullable List<String> fixedTopics, @Nullable Pattern topicPattern) {
checkArgument(
- (fixedTopics != null && topicPattern == null)
- || (fixedTopics == null && topicPattern != null),
- "Exactly one of either fixedTopics or topicPattern must be specified.");
+ (fixedTopics != null && topicPattern == null)
+ || (fixedTopics == null && topicPattern != null),
+ "Exactly one of either fixedTopics or topicPattern must be specified.");
if (fixedTopics != null) {
checkArgument(
- !fixedTopics.isEmpty(),
- "If subscribing to a fixed topics list, the supplied list cannot be empty.");
+ !fixedTopics.isEmpty(),
+ "If subscribing to a fixed topics list, the supplied list cannot be empty.");
+ fixedTopics.forEach(topic -> {
+ checkNotNull(topic, "An null topic exists in the subscribed topics list.");
+ checkArgument(!"".equals(topic), "An empty topic exists in the subscribed topics list.");
+ });
}
+ if (topicPattern != null) {
Review comment:
It's no need to check topicPattern is empty or not, it's legal if topicPattern is empty.
we can just delete the statement 'if (topicPattern != null) { ... }'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LongWangXX commented on pull request #16417: FLINK-22969
Posted by GitBox <gi...@apache.org>.
LongWangXX commented on pull request #16417:
URL: https://github.com/apache/flink/pull/16417#issuecomment-877737618
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org