You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/10/28 10:06:21 UTC

[GitHub] flink pull request #2711: [backport] [FLINK-4932] [exec graph] Failing in st...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/2711

    [backport] [FLINK-4932] [exec graph] Failing in state RESTARTING only fails the EG if no more restarts are possible

    This PR is a backport of #2710 for the release-1.1 branch.
    
    If in state RESTARTING a failure occurs (`ExecutionGraph.fail` is called), then a new restart attempt is started. Only if the restart strategy no longer allows further restarts or if the thrown exception is of type SuppressRestartsException a job can go from RESTARTING into FAILED.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink backportFixRestartingState

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2711.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2711
    
----
commit 920dbe6ac5969c63d9725f0999c3cd1adfa70fad
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-10-27T16:32:08Z

    [FLINK-4932] [exec graph] Failing in state RESTARTING only fails the EG if no more restarts are possible
    
    If in state RESTARTING a failure occurs, then a new restart attempt is started. Only if the
    restart strategy no longer allows further restarts or if the thrown exception is of type
    SuppressRestartsException a job can go from RESTARTING into FAILED.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2711: [backport] [FLINK-4932] [exec graph] Failing in st...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann closed the pull request at:

    https://github.com/apache/flink/pull/2711


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2711: [backport] [FLINK-4932] [exec graph] Failing in state RES...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2711
  
    Thanks for the review @uce. @StephanEwen actually discovered this problem. The problem was related to #2700. When the scheduleOrUpdateConsumers call was triggered when in state restarting due to a late rpc, it would fail the complete `ExecutionGraph`, because it could not find the respective `Execution`.
    
    Will rebase the PR, because release-1.1 contained a problem which prevented it from building.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2711: [backport] [FLINK-4932] [exec graph] Failing in state RES...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2711
  
    Thanks for the fix!
    Looks good, merging this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2711: [backport] [FLINK-4932] [exec graph] Failing in state RES...

Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:

    https://github.com/apache/flink/pull/2711
  
    Code changes and updated figure look good to me. +1 to merge after Travis passes. It makes sense that for instance a job with infinite restarts will only be failed if the job is explicitly suspended or forced to suppress restarts. I was curious how you noticed this issue? Did a user run into this? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2711: [backport] [FLINK-4932] [exec graph] Failing in state RES...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2711
  
    Closing this because it has been merged into the release 1.1 branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---