You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Elliott Clark (JIRA)" <ji...@apache.org> on 2012/10/04 23:37:48 UTC
[jira] [Created] (HBASE-6952) Clean up some of the Client tests for
exceptions.
Elliott Clark created HBASE-6952:
------------------------------------
Summary: Clean up some of the Client tests for exceptions.
Key: HBASE-6952
URL: https://issues.apache.org/jira/browse/HBASE-6952
Project: HBase
Issue Type: Improvement
Reporter: Elliott Clark
Assignee: Aleksandr Shulman
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6952) Clean up some of the Client tests
for exceptions.
Posted by "Aleksandr Shulman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469755#comment-13469755 ]
Aleksandr Shulman commented on HBASE-6952:
------------------------------------------
An example of the above might be something like this:
try {
do_something_that_we_expect_to_throw_an_exception()
//fail should be here!
} catch (Exception e) {
//logic for handling expected exception
}
If there is no fail there, then the code has not done something that the test expected it to do. Hence it should fail.
> Clean up some of the Client tests for exceptions.
> -------------------------------------------------
>
> Key: HBASE-6952
> URL: https://issues.apache.org/jira/browse/HBASE-6952
> Project: HBase
> Issue Type: Improvement
> Components: Client, test
> Reporter: Elliott Clark
> Assignee: Aleksandr Shulman
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6952) Clean up some of the Client tests for
exceptions.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6952:
---------------------------------
Component/s: test
Client
> Clean up some of the Client tests for exceptions.
> -------------------------------------------------
>
> Key: HBASE-6952
> URL: https://issues.apache.org/jira/browse/HBASE-6952
> Project: HBase
> Issue Type: Improvement
> Components: Client, test
> Reporter: Elliott Clark
> Assignee: Aleksandr Shulman
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6952) Clean up some of the Client tests
for exceptions.
Posted by "Aleksandr Shulman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469751#comment-13469751 ]
Aleksandr Shulman commented on HBASE-6952:
------------------------------------------
The first task is to identify test suites that have some try-catch testing anti-patterns.
An example is TestAdmin.java.
> Clean up some of the Client tests for exceptions.
> -------------------------------------------------
>
> Key: HBASE-6952
> URL: https://issues.apache.org/jira/browse/HBASE-6952
> Project: HBase
> Issue Type: Improvement
> Components: Client, test
> Reporter: Elliott Clark
> Assignee: Aleksandr Shulman
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6952) Clean up some of the Client tests
for exceptions.
Posted by "Aleksandr Shulman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469756#comment-13469756 ]
Aleksandr Shulman commented on HBASE-6952:
------------------------------------------
Another example might be not asserting the exception's message.
> Clean up some of the Client tests for exceptions.
> -------------------------------------------------
>
> Key: HBASE-6952
> URL: https://issues.apache.org/jira/browse/HBASE-6952
> Project: HBase
> Issue Type: Improvement
> Components: Client, test
> Reporter: Elliott Clark
> Assignee: Aleksandr Shulman
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6952) Clean up some of the Client tests
for exceptions.
Posted by "Aleksandr Shulman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469758#comment-13469758 ]
Aleksandr Shulman commented on HBASE-6952:
------------------------------------------
Thirdly, we should be watching out for general exceptions (e.g. catch(Exception e)). We want to have as tight of an exception as possible so unexpected exceptions do not fail silently.
> Clean up some of the Client tests for exceptions.
> -------------------------------------------------
>
> Key: HBASE-6952
> URL: https://issues.apache.org/jira/browse/HBASE-6952
> Project: HBase
> Issue Type: Improvement
> Components: Client, test
> Reporter: Elliott Clark
> Assignee: Aleksandr Shulman
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira