You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Timothy Chen <tn...@gmail.com> on 2012/10/25 19:31:13 UTC
Add patch to reviewboard?
Hi all,
I've submitted a patch for my very first PIG bug 2 days ago,
https://issues.apache.org/jira/browse/PIG-2507.
I wonder if it is standard process to add every patch to reviewboard?
Thanks,
Tim
Re: Add patch to reviewboard?
Posted by Prashant Kommireddi <pr...@gmail.com>.
So here goes a poke from me :)
PIG-2832, 2582, 2997, 2933
On Oct 26, 2012, at 3:40 PM, Jonathan Coveney <jc...@gmail.com> wrote:
> Poking is integral to the apache process :)
>
> 2012/10/26 Alan Gates <ga...@hortonworks.com>
>
>> Yeah, feel free to keep poking us until someone takes it up.
>>
>> Alan.
>>
>> On Oct 25, 2012, at 10:47 AM, Timothy Chen wrote:
>>
>>> Gotcha, my patch is very small so I'll leave it in the JIRA issue then.
>>>
>>> I see a bunch of issues in JIRA with patch available but no one really
>>> looking at it, should I just come back and bug the list every week if it
>>> just stays there?
>>>
>>> Tim
>>>
>>> On Thu, Oct 25, 2012 at 10:45 AM, Alan Gates <ga...@hortonworks.com>
>> wrote:
>>>
>>>> In Pig we leave the use of reviewboard up to the contributor and
>> reviewer.
>>>> If you find it helpful feel free to use it. A reviewer may also ask for
>>>> it, especially if the patch is large. But we do not require all
>> patches be
>>>> placed there.
>>>>
>>>> Alan.
>>>>
>>>> On Oct 25, 2012, at 1:31 PM, Timothy Chen wrote:
>>>>
>>>>> Hi all,
>>>>>
>>>>> I've submitted a patch for my very first PIG bug 2 days ago,
>>>>> https://issues.apache.org/jira/browse/PIG-2507.
>>>>>
>>>>> I wonder if it is standard process to add every patch to reviewboard?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Tim
>>>>
>>>>
>>
>>
Re: Add patch to reviewboard?
Posted by Jonathan Coveney <jc...@gmail.com>.
Poking is integral to the apache process :)
2012/10/26 Alan Gates <ga...@hortonworks.com>
> Yeah, feel free to keep poking us until someone takes it up.
>
> Alan.
>
> On Oct 25, 2012, at 10:47 AM, Timothy Chen wrote:
>
> > Gotcha, my patch is very small so I'll leave it in the JIRA issue then.
> >
> > I see a bunch of issues in JIRA with patch available but no one really
> > looking at it, should I just come back and bug the list every week if it
> > just stays there?
> >
> > Tim
> >
> > On Thu, Oct 25, 2012 at 10:45 AM, Alan Gates <ga...@hortonworks.com>
> wrote:
> >
> >> In Pig we leave the use of reviewboard up to the contributor and
> reviewer.
> >> If you find it helpful feel free to use it. A reviewer may also ask for
> >> it, especially if the patch is large. But we do not require all
> patches be
> >> placed there.
> >>
> >> Alan.
> >>
> >> On Oct 25, 2012, at 1:31 PM, Timothy Chen wrote:
> >>
> >>> Hi all,
> >>>
> >>> I've submitted a patch for my very first PIG bug 2 days ago,
> >>> https://issues.apache.org/jira/browse/PIG-2507.
> >>>
> >>> I wonder if it is standard process to add every patch to reviewboard?
> >>>
> >>> Thanks,
> >>>
> >>> Tim
> >>
> >>
>
>
Re: Add patch to reviewboard?
Posted by Alan Gates <ga...@hortonworks.com>.
Yeah, feel free to keep poking us until someone takes it up.
Alan.
On Oct 25, 2012, at 10:47 AM, Timothy Chen wrote:
> Gotcha, my patch is very small so I'll leave it in the JIRA issue then.
>
> I see a bunch of issues in JIRA with patch available but no one really
> looking at it, should I just come back and bug the list every week if it
> just stays there?
>
> Tim
>
> On Thu, Oct 25, 2012 at 10:45 AM, Alan Gates <ga...@hortonworks.com> wrote:
>
>> In Pig we leave the use of reviewboard up to the contributor and reviewer.
>> If you find it helpful feel free to use it. A reviewer may also ask for
>> it, especially if the patch is large. But we do not require all patches be
>> placed there.
>>
>> Alan.
>>
>> On Oct 25, 2012, at 1:31 PM, Timothy Chen wrote:
>>
>>> Hi all,
>>>
>>> I've submitted a patch for my very first PIG bug 2 days ago,
>>> https://issues.apache.org/jira/browse/PIG-2507.
>>>
>>> I wonder if it is standard process to add every patch to reviewboard?
>>>
>>> Thanks,
>>>
>>> Tim
>>
>>
Re: Add patch to reviewboard?
Posted by Timothy Chen <tn...@gmail.com>.
Gotcha, my patch is very small so I'll leave it in the JIRA issue then.
I see a bunch of issues in JIRA with patch available but no one really
looking at it, should I just come back and bug the list every week if it
just stays there?
Tim
On Thu, Oct 25, 2012 at 10:45 AM, Alan Gates <ga...@hortonworks.com> wrote:
> In Pig we leave the use of reviewboard up to the contributor and reviewer.
> If you find it helpful feel free to use it. A reviewer may also ask for
> it, especially if the patch is large. But we do not require all patches be
> placed there.
>
> Alan.
>
> On Oct 25, 2012, at 1:31 PM, Timothy Chen wrote:
>
> > Hi all,
> >
> > I've submitted a patch for my very first PIG bug 2 days ago,
> > https://issues.apache.org/jira/browse/PIG-2507.
> >
> > I wonder if it is standard process to add every patch to reviewboard?
> >
> > Thanks,
> >
> > Tim
>
>
Re: Add patch to reviewboard?
Posted by Alan Gates <ga...@hortonworks.com>.
In Pig we leave the use of reviewboard up to the contributor and reviewer. If you find it helpful feel free to use it. A reviewer may also ask for it, especially if the patch is large. But we do not require all patches be placed there.
Alan.
On Oct 25, 2012, at 1:31 PM, Timothy Chen wrote:
> Hi all,
>
> I've submitted a patch for my very first PIG bug 2 days ago,
> https://issues.apache.org/jira/browse/PIG-2507.
>
> I wonder if it is standard process to add every patch to reviewboard?
>
> Thanks,
>
> Tim