You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "hello-stephen (via GitHub)" <gi...@apache.org> on 2023/08/21 08:07:27 UTC
[GitHub] [doris] hello-stephen opened a new pull request, #23259: [fix](case) comment out orthogonal_bitmap_intersect
hello-stephen opened a new pull request, #23259:
URL: https://github.com/apache/doris/pull/23259
## Proposed changes
This case often fails in the internal test pipeline. After discussion, the related parts of orthogonal_bitmap_intersect are commented out first.
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23259: [fix](case) comment out orthogonal_bitmap_intersect
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23259:
URL: https://github.com/apache/doris/pull/23259#issuecomment-1685854487
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23259: [fix](case) comment out orthogonal_bitmap_intersect
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23259:
URL: https://github.com/apache/doris/pull/23259#issuecomment-1686183250
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23259: [fix](case) comment out orthogonal_bitmap_*
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23259:
URL: https://github.com/apache/doris/pull/23259#issuecomment-1686323196
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23259: [fix](case) comment out orthogonal_bitmap_intersect
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23259:
URL: https://github.com/apache/doris/pull/23259#issuecomment-1686208795
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #23259: [fix](case) comment out orthogonal_bitmap_*
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #23259:
URL: https://github.com/apache/doris/pull/23259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23259: [fix](case) comment out orthogonal_bitmap_*
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23259:
URL: https://github.com/apache/doris/pull/23259#issuecomment-1687300680
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #23259: [fix](case) comment out orthogonal_bitmap_intersect
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #23259:
URL: https://github.com/apache/doris/pull/23259#discussion_r1299895973
##########
regression-test/suites/query_p0/sql_functions/bitmap_functions/test_bitmap_function.groovy:
##########
@@ -690,146 +690,146 @@ suite("test_bitmap_function") {
test_bitmap1;
"""
- sql """
- drop TABLE if exists test_bitmap_intersect;
- """
-
- sql """
- CREATE TABLE test_bitmap_intersect (
- dt1 date NOT NULL,
- dt2 date NOT NULL,
- id varchar(256) NULL,
- type smallint(6) MAX NULL,
- id_bitmap bitmap BITMAP_UNION NULL
- ) ENGINE = OLAP AGGREGATE KEY(dt1, dt2, id) PARTITION BY RANGE(dt1) (
- PARTITION p20230725
- VALUES
- [('2023-07-25'), ('2023-07-26')))
- DISTRIBUTED BY HASH(dt1, dt2) BUCKETS 1 properties("replication_num"="1");
- """
-
- sql """
- insert into test_bitmap_intersect
- select
- str_to_date('2023-07-25','%Y-%m-%d') as dt1,
- str_to_date('2023-07-25','%Y-%m-%d') as dt2,
- 'aaaaaaaaaa' as id,
- 1 as type,
- BITMAP_HASH64('aaaaaaaaaa') as id_bitmap;
- """
- qt_sql_bitmap_intersect_check0 """
- select intersect_count(id_bitmap, type, 1) as count2_bitmap from test_bitmap_intersect;
- """
- qt_sql_bitmap_intersect_check1 """
- select bitmap_count(orthogonal_bitmap_intersect(id_bitmap, type, 1)) as count2_bitmap from test_bitmap_intersect;
- """
- qt_sql_bitmap_intersect_check2 """
- select orthogonal_bitmap_intersect_count(id_bitmap, type, 1) as count2_bitmap from test_bitmap_intersect;
- """
-
- // test function intersect_count
- // test nereids
- sql """ set experimental_enable_nereids_planner=true; """
- // test pipeline
- sql """ set experimental_enable_pipeline_engine=true; """
- qt_sql_bitmap_intersect_nereids0 """
- select count(distinct if(type=1, id,null)) as count1,
- intersect_count(id_bitmap, type, 1) as count2_bitmap from test_bitmap_intersect;
- """
- sql """ set experimental_enable_pipeline_engine=false; """
- qt_sql_bitmap_intersect_nereids1 """
- select count(distinct if(type=1, id,null)) as count1,
Review Comment:
why delete this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org