You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2019/12/30 12:11:34 UTC
[GitHub] [httpcomponents-client] michael-o opened a new pull request #193:
Authschemename rework
michael-o opened a new pull request #193: Authschemename rework
URL: https://github.com/apache/httpcomponents-client/pull/193
As mentioned, here is the consistency proposal for the auth scheme topic. Please also note the elaborated commit messages explaining the reasoning behind this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on issue #193:
Authschemename rework
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #193: Authschemename rework
URL: https://github.com/apache/httpcomponents-client/pull/193#issuecomment-570086437
@garydgregory I have now reconciled with subsequent cleanup. Please have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] garydgregory commented on issue #193:
Authschemename rework
Posted by GitBox <gi...@apache.org>.
garydgregory commented on issue #193: Authschemename rework
URL: https://github.com/apache/httpcomponents-client/pull/193#issuecomment-570062747
@michael-o
I could go either way here. We have an almost 1-1 mapping before this patch between the enum and the interface impls (except for one impl marked experimental.) But of course, the enum and impls know nothing of each other. It is also not possible for the enum to implement an interface since each impl carries state. At least a simple port to this 'enum implements an interface' is not there, but something better might still be possible.
I see the current code base as disconnected since the enum, interface and impls don't really tie in to each other. So this patch seems ok. I'll leave it up to you :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on issue #193:
Authschemename rework
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #193: Authschemename rework
URL: https://github.com/apache/httpcomponents-client/pull/193#issuecomment-570063434
Ok, I think I have an idea how to reconcile both ideas, since we have classes and enums, e.g., HttpStatus, EventFilter singular and enums are exhaustive in nature, I think think can be "class StandardAuthScheme". I will work on an update this evening.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] asfgit merged pull request #193:
Authschemename rework
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #193: Authschemename rework
URL: https://github.com/apache/httpcomponents-client/pull/193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org