You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/08/23 13:20:54 UTC

[commons-text] 04/06: Constructor package-private -> private

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-text.git

commit a2bcf8d29bc85842c9e635bd1f34916e62c2c739
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Aug 23 09:18:49 2023 -0400

    Constructor package-private -> private
---
 src/changes/changes.xml                                               | 1 +
 .../java/org/apache/commons/text/lookup/UrlEncoderStringLookup.java   | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 9e610940..431e17bf 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -65,6 +65,7 @@ The <action> type attribute can be add,update,fix,remove.
     <action issue="TEXT-228" type="fix" dev="ggregory" due-to="Alex Herbert, Gary Gregory">Fix TextStringBuilder to over-allocate when ensuring capacity #452.</action>
     <action                  type="fix" dev="ggregory" due-to="Elliotte Rusty Harold, Gary Gregory">Constructor for ResourceBundleStringLookup should be private instead of package-private.</action>
     <action                  type="fix" dev="ggregory" due-to="Elliotte Rusty Harold, Gary Gregory">Constructor for UrlDecoderStringLookup should be private instead of package-private.</action>
+    <action                  type="fix" dev="ggregory" due-to="Elliotte Rusty Harold, Gary Gregory">Constructor for UrlEncoderStringLookup should be private instead of package-private.</action>
     <!-- ADD -->
     <action issue="TEXT-224" type="add" dev="ggregory" due-to="PJ Fanning, Gary Gregory">Set SecureProcessing feature in XmlStringLookup by default.</action>
     <action issue="TEXT-224" type="add" dev="ggregory" due-to="Gary Gregory">Add StringLookupFactory.xmlStringLookup(Map&lt;String, Boolean&gt;...).</action>
diff --git a/src/main/java/org/apache/commons/text/lookup/UrlEncoderStringLookup.java b/src/main/java/org/apache/commons/text/lookup/UrlEncoderStringLookup.java
index 62513aa7..a439017e 100644
--- a/src/main/java/org/apache/commons/text/lookup/UrlEncoderStringLookup.java
+++ b/src/main/java/org/apache/commons/text/lookup/UrlEncoderStringLookup.java
@@ -35,9 +35,9 @@ final class UrlEncoderStringLookup extends AbstractStringLookup {
     static final UrlEncoderStringLookup INSTANCE = new UrlEncoderStringLookup();
 
     /**
-     * This ctor is not private to allow Mockito spying.
+     * Constructs a new instance.
      */
-    UrlEncoderStringLookup() {
+    private UrlEncoderStringLookup() {
         // empty
     }