You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Pradeep Kamath (JIRA)" <ji...@apache.org> on 2008/07/24 22:49:31 UTC

[jira] Created: (PIG-336) is null does not work in a AND

is null does not work in a AND
------------------------------

                 Key: PIG-336
                 URL: https://issues.apache.org/jira/browse/PIG-336
             Project: Pig
          Issue Type: Bug
    Affects Versions: types_branch
            Reporter: Pradeep Kamath
            Assignee: Pradeep Kamath
             Fix For: types_branch


The following code currently does not work
{code}
B = filter A by $0 is null and $1 is null;
{code}



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-336) is null does not work in a AND

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-336:
-------------------------------

    Attachment: PIG-336.patch

Attached a patch to fix is null issues

> is null does not work in a AND
> ------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-336) NULL checks are not in place in the types branch

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan Gates updated PIG-336:
---------------------------

    Priority: Critical  (was: Major)

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-336) NULL checks are not in place in the types branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-336:
-------------------------------

    Attachment: PIG-336.patch

New patch which addresses many issues with handling nulls and also adds many unit test cases dealing with null data.





> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-336) NULL checks are not in place in the types branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628754#action_12628754 ] 

Pradeep Kamath commented on PIG-336:
------------------------------------

Some more of the existing unit test cases which still need to be potentially modified to test for null input data are:
TestEvalPipeline
TestFilterOpNumeric
TestFilterUDF
TestPigSplit
TestPOGenerate
TestPOMapLookup
TestSplitStore
TestStore
TestStoreOld
TestUnion

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336-part1_v2.patch, PIG-336-part1_v3.patch, PIG-336-part1_v4.patch, PIG-336-part2.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-336) NULL checks are not in place in the types branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-336:
-------------------------------

    Attachment: PIG-336-part2.patch

Attached patch with modifications to some of the existing unit test cases to test with null data

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336-part1_v2.patch, PIG-336-part1_v3.patch, PIG-336-part1_v4.patch, PIG-336-part2.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-336) NULL checks are not in place in the types branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629239#action_12629239 ] 

Olga Natkovich commented on PIG-336:
------------------------------------

PIG-336-part2.patch committed; thanks, pradeep.

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336-part1_v2.patch, PIG-336-part1_v3.patch, PIG-336-part1_v4.patch, PIG-336-part2.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-336) NULL checks are not in place in the types branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-336:
-------------------------------

    Attachment: PIG-336-part1.patch

Resubmitting patch with a minor delta - change in test/org/apache/pig/test/util/GenRandomData.java to make the random null data generation more correct.

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-336) NULL checks are not in place in the types branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-336:
-------------------------------

    Attachment: PIG-336-part1_v2.patch

Attached patch for changes noted in previous comment

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336-part1_v2.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-336) NULL checks are not in place in the types branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-336:
-------------------------------

    Description: 
The following code currently does not work
{code}
B = filter A by $0 is null and $1 is null;
{code}

Some other things which don't work with nulls include POAND, POOR etc


  was:
The following code currently does not work
{code}
B = filter A by $0 is null and $1 is null;
{code}



        Summary: NULL checks are not in place in the types branch  (was: is null does not work in a AND)

I am currently working on adding null in data for unit test cases so that testing with nulls is part of unit test cases. I am also trying to fix code issues along the way - will have a bigger patch once done.

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-336) NULL checks are not in place in the types branch

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan Gates updated PIG-336:
---------------------------

    Status: Patch Available  (was: Open)

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336-part1_v2.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-336) NULL checks are not in place in the types branch

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620377#action_12620377 ] 

Alan Gates commented on PIG-336:
--------------------------------

part1_v4 patch checked in.  Thanks Pradeep for all your work on this.

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336-part1_v2.patch, PIG-336-part1_v3.patch, PIG-336-part1_v4.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-336) NULL checks are not in place in the types branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618908#action_12618908 ] 

Pradeep Kamath commented on PIG-336:
------------------------------------

I will be resubmitting the patch to work with latest revision in svn and also to fix a bug in the expressions ops - eq, lt, lte, neq, gt and gte

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-336) NULL checks are not in place in the types branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-336:
-------------------------------

    Attachment:     (was: PIG-336.patch)

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-336) NULL checks are not in place in the types branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617255#action_12617255 ] 

Pradeep Kamath commented on PIG-336:
------------------------------------

One thing I noticed while working on fixing null issues in arithmetic operations is currently the return type for Integer multiplication and addition is an Integer.This could give wrong results when the integers are big and the multiplication results in a value which cannot be stored in an integer - Should the result be a Long?

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-336) NULL checks are not in place in the types branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-336:
-------------------------------

    Attachment: PIG-336-part1_v3.patch

Attached patch compatible with current svn version. This patch does not handle nulls in joins/group/cogroup and sort

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336-part1_v2.patch, PIG-336-part1_v3.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-336) NULL checks are not in place in the types branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-336:
-------------------------------

    Attachment: PIG-336-part1_v4.patch

Attached patch to address review comments.
Delta to previous patch:


- Removed TestOrderBy changes - we should revisit this after order desc is fixed

- NullableXXX classes have a change in the compareTo():
If both the objects being compared are nulls, it returns a 0 - this enables all nulls to collapse during a group by

-keyDiscoverKeyTypeVisitor has been changed to visit MROperPlan
 Supporting changes are in JobControlCompiler, PigMapBase, LocalLauncher,MapReduceLauncher, MapReduceOper, PigCombiner, 

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336-part1_v2.patch, PIG-336-part1_v3.patch, PIG-336-part1_v4.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-336) NULL checks are not in place in the types branch

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620110#action_12620110 ] 

Alan Gates commented on PIG-336:
--------------------------------

This patch looks great.  What a pile of work!

I have one comment.  The KeyTypeDiscoverVisitor is used in the map and combine sections PigMapReduce and PigCombiner.  This should be done sooner.  Those classes are focussed on actual execution, not execution planning.  I think you're waiting until then because you only want to visit specific pieces of the physical plan in each map, combine, or reduce phase.  If that's the case, you should instead run this visitor in MapReduceLauncher and LocalLauncher, where the physical plan is compiled into a map reduce plan.  (Look for CombinerOptimizer, you should run the KeyTypeDiscoveryVisitor right after that.)  You can then record that information in the MapReduceOper itself, and read that in PigMapReduce and PigCombiner.

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>            Priority: Critical
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336-part1_v2.patch, PIG-336-part1_v3.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-336) NULL checks are not in place in the types branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-336:
-------------------------------

    Status: Open  (was: Patch Available)

all existing patches has been applied

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336-part1_v2.patch, PIG-336-part1_v3.patch, PIG-336-part1_v4.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-336) NULL checks are not in place in the types branch

Posted by "Pi Song (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617398#action_12617398 ] 

Pi Song commented on PIG-336:
-----------------------------

Long can be overflown as well. Moving from int to long will just lower possibility. This is the same as our aggregate functions (SUM for example). I agree with anything that most people think is good.

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-336) NULL checks are not in place in the types branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-336:
-------------------------------

    Priority: Major  (was: Critical)

lowering priority to major since most of this has already 

> NULL checks are not in place in the types branch
> ------------------------------------------------
>
>                 Key: PIG-336
>                 URL: https://issues.apache.org/jira/browse/PIG-336
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-336-part1.patch, PIG-336-part1_v2.patch, PIG-336-part1_v3.patch, PIG-336-part1_v4.patch, PIG-336.patch
>
>
> The following code currently does not work
> {code}
> B = filter A by $0 is null and $1 is null;
> {code}
> Some other things which don't work with nulls include POAND, POOR etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.