You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Daniel Pravat <dp...@outlook.com> on 2016/03/08 19:10:53 UTC

Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41632/
-----------------------------------------------------------

(Updated March 8, 2016, 6:10 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Summary (updated)
-----------------

Windows: Added Console Ctrl handling in `slave.cpp`.


Bugs: MESOS-3644
    https://issues.apache.org/jira/browse/MESOS-3644


Repository: mesos


Description (updated)
-------

Windows: Added Console Ctrl handling in `slave.cpp`.


Diffs (updated)
-----

  src/slave/posix_signalhandler.hpp PRE-CREATION 
  src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
  src/slave/windows_ctrlhandler.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41632/diff/


Testing
-------

OSX: make check
Windows: make


Thanks,

Daniel Pravat


Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41632/
-----------------------------------------------------------

(Updated April 21, 2016, 8:47 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3644
    https://issues.apache.org/jira/browse/MESOS-3644


Repository: mesos


Description
-------

Windows: Added Console Ctrl handling in `slave.cpp`.


Diffs (updated)
-----

  src/slave/posix_signalhandler.hpp PRE-CREATION 
  src/slave/slave.cpp d82dec2b10d496065013eb4ad6a35dc054b72553 
  src/slave/windows_ctrlhandler.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41632/diff/


Testing
-------

OSX: make check
Windows: make


Thanks,

Daniel Pravat


Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41632/
-----------------------------------------------------------

(Updated March 8, 2016, 6:15 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3644
    https://issues.apache.org/jira/browse/MESOS-3644


Repository: mesos


Description
-------

Windows: Added Console Ctrl handling in `slave.cpp`.


Diffs (updated)
-----

  src/slave/posix_signalhandler.hpp PRE-CREATION 
  src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
  src/slave/windows_ctrlhandler.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41632/diff/


Testing
-------

OSX: make check
Windows: make


Thanks,

Daniel Pravat