You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Brian Spindler <da...@gmail.com> on 2013/03/25 21:35:25 UTC
Review Request: BugFix CLOUDSTACK-1803: Slashes removed from local storage
path
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10124/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Fix for deleting all slashes from the storage path instead of just the first slash.
This addresses bug CLOUDSTACK-1803.
Diffs
-----
plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java 2991574
Diff: https://reviews.apache.org/r/10124/diff/
Testing
-------
Ubuntu 12.04, turned local storage on, added a physical host.
Thanks,
Brian Spindler
Re: Review Request: BugFix CLOUDSTACK-1803: Slashes removed from local
storage path
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10124/#review18409
-----------------------------------------------------------
Ship it!
Ship It!
- edison su
On March 25, 2013, 8:41 p.m., Brian Spindler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10124/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 8:41 p.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Description
> -------
>
> Fix for deleting all slashes from the storage path instead of just the first slash.
>
>
> This addresses bug CLOUDSTACK-1803.
>
>
> Diffs
> -----
>
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java 2991574
>
> Diff: https://reviews.apache.org/r/10124/diff/
>
>
> Testing
> -------
>
> Ubuntu 12.04, turned local storage on, added a physical host.
>
>
> Thanks,
>
> Brian Spindler
>
>
Re: Review Request: BugFix CLOUDSTACK-1803: Slashes removed from local
storage path
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10124/#review18388
-----------------------------------------------------------
+1 Looks good, should fix the issue. Waiting for Edison to take a final look at it and give a ship it.
Will assign the issue to Edison on JIRA.
- Rohit Yadav
On March 25, 2013, 8:41 p.m., Brian Spindler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10124/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 8:41 p.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Description
> -------
>
> Fix for deleting all slashes from the storage path instead of just the first slash.
>
>
> This addresses bug CLOUDSTACK-1803.
>
>
> Diffs
> -----
>
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java 2991574
>
> Diff: https://reviews.apache.org/r/10124/diff/
>
>
> Testing
> -------
>
> Ubuntu 12.04, turned local storage on, added a physical host.
>
>
> Thanks,
>
> Brian Spindler
>
>
Re: Review Request: BugFix CLOUDSTACK-1803: Slashes removed from local
storage path
Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10124/#review18410
-----------------------------------------------------------
Edison committed this:
Branch: refs/heads/master
Commit: 99bcfd24c70d751d0222944d15a468a6017fb660
Parents: 5df32e6
Author: Brian Spindler <da...@gmail.com>
Authored: Mon Mar 25 13:20:27 2013 -0700
Committer: Edison Su <su...@gmail.com>
Committed: Tue Mar 26 17:36:29 2013 -0700
- David Nalley
On March 25, 2013, 8:41 p.m., Brian Spindler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10124/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 8:41 p.m.)
>
>
> Review request for cloudstack and edison su.
>
>
> Description
> -------
>
> Fix for deleting all slashes from the storage path instead of just the first slash.
>
>
> This addresses bug CLOUDSTACK-1803.
>
>
> Diffs
> -----
>
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java 2991574
>
> Diff: https://reviews.apache.org/r/10124/diff/
>
>
> Testing
> -------
>
> Ubuntu 12.04, turned local storage on, added a physical host.
>
>
> Thanks,
>
> Brian Spindler
>
>
Re: Review Request: BugFix CLOUDSTACK-1803: Slashes removed from local
storage path
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10124/
-----------------------------------------------------------
(Updated March 25, 2013, 8:41 p.m.)
Review request for cloudstack and edison su.
Changes
-------
Adding Edison to this review.
Setting branch to "master".
Description
-------
Fix for deleting all slashes from the storage path instead of just the first slash.
This addresses bug CLOUDSTACK-1803.
Diffs
-----
plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java 2991574
Diff: https://reviews.apache.org/r/10124/diff/
Testing
-------
Ubuntu 12.04, turned local storage on, added a physical host.
Thanks,
Brian Spindler