[GitHub] [incubator-doris] imay commented on a change in pull request #2422: Add copy_object() method for HLL columns when loading

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2422: Add copy_object() method for HLL columns when loading
URL: https://github.com/apache/incubator-doris/pull/2422#discussion_r356352458
 
 

 ##########
 File path: be/src/olap/row.h
 ##########
 @@ -134,6 +134,19 @@ void copy_row(DstRowType* dst, const SrcRowType& src, MemPool* pool) {
     }
 }
 
+// NOTE: only use in MemTable for now, it is same with copy_row(), but for HLL and Object type,
+// its content is in Slice->data, other than a normal Slice, so we just assign the Slice->data
+// pointer, instead of memcpy the data.
+// TODO(lingbin): remove this method
+template<typename DstRowType, typename SrcRowType>
+void copy_row_in_memtable(DstRowType* dst, const SrcRowType& src, MemPool* pool) {
 
 Review comment:
   If this is only used for MemTable, is the template necessary?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org