You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Aditi Dixit <ad...@gmail.com> on 2015/06/03 08:11:40 UTC

Review Request 34984: Added help for files

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34984/
-----------------------------------------------------------

Review request for mesos, Niklas Nielsen and Vinod Kone.


Bugs: MESOS-2277
    https://issues.apache.org/jira/browse/MESOS-2277


Repository: mesos


Description
-------

Added help for files


Diffs
-----

  src/files/files.cpp ce02411c5e579d7551b4325ec141fd89e4ee7255 

Diff: https://reviews.apache.org/r/34984/diff/


Testing
-------

make check


Thanks,

Aditi Dixit

Re: Review Request 34984: Added help for files

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34984/#review86374
-----------------------------------------------------------


Patch looks great!

Reviews applied: [34984]

All tests passed.

- Mesos ReviewBot


On June 3, 2015, 6:11 a.m., Aditi Dixit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34984/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 6:11 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2277
>     https://issues.apache.org/jira/browse/MESOS-2277
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added help for files
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp ce02411c5e579d7551b4325ec141fd89e4ee7255 
> 
> Diff: https://reviews.apache.org/r/34984/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 34984: Added help for files

Posted by Vinod Kone <vi...@gmail.com>.

> On June 3, 2015, 7:01 p.m., Niklas Nielsen wrote:
> > Thanks for taking this on, Aditi!
> > 
> > I listed a few suggestions below

Aditi, can you please resolve the issues by clicking the "Fixed" button on the issues below? Please see the guidelines here: http://mesos.apache.org/documentation/latest/submitting-a-patch/.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34984/#review86463
-----------------------------------------------------------


On June 4, 2015, 9:40 a.m., Aditi Dixit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34984/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 9:40 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2277
>     https://issues.apache.org/jira/browse/MESOS-2277
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added help for files
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp ce02411c5e579d7551b4325ec141fd89e4ee7255 
> 
> Diff: https://reviews.apache.org/r/34984/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 34984: Added help for files

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34984/#review86463
-----------------------------------------------------------


Thanks for taking this on, Aditi!

I listed a few suggestions below


src/files/files.cpp
<https://reviews.apache.org/r/34984/#comment138492>

    Should be in lexicographical order :) Would you mind sorting these please?



src/files/files.cpp
<https://reviews.apache.org/r/34984/#comment138494>

    The alignment seems a bit off, shouldn't be:
    
    ```
    route("/foobar.json",
          FooProcess::BAR_HELP,
          &FooProcess::bar);
    ```
    
    ?
    
    Here and below



src/files/files.cpp
<https://reviews.apache.org/r/34984/#comment138495>

    This endpoint supports queries like:
    
    /files/browse.json?path=foobar
    
    Can you document the query parameters too?
    Here and below



src/files/files.cpp
<https://reviews.apache.org/r/34984/#comment138496>

    Read supports 'path', 'offset' and 'length' query parameters - mind documenting those too?



src/files/files.cpp
<https://reviews.apache.org/r/34984/#comment138497>

    This supports the path parameter too, mind documenting it?
    Thanks! :)


- Niklas Nielsen


On June 2, 2015, 11:11 p.m., Aditi Dixit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34984/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 11:11 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2277
>     https://issues.apache.org/jira/browse/MESOS-2277
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added help for files
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp ce02411c5e579d7551b4325ec141fd89e4ee7255 
> 
> Diff: https://reviews.apache.org/r/34984/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 34984: Added help for files

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34984/#review86583
-----------------------------------------------------------


Patch looks great!

Reviews applied: [34984]

All tests passed.

- Mesos ReviewBot


On June 4, 2015, 9:40 a.m., Aditi Dixit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34984/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 9:40 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2277
>     https://issues.apache.org/jira/browse/MESOS-2277
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added help for files
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp ce02411c5e579d7551b4325ec141fd89e4ee7255 
> 
> Diff: https://reviews.apache.org/r/34984/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 34984: Added help for files

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34984/#review86849
-----------------------------------------------------------

Ship it!


I will make the change for you below. Thanks Aditi!


src/files/files.cpp
<https://reviews.apache.org/r/34984/#comment138950>

    Should be:
    
    ```
    using process::DESCRIPTION;
    using process::HELP;
    using process::TLDR;
    using process::USAGE;
    using process::wait; // Necessary on some OS's to disambiguate.
    ```
    
    Underneath 'using namespace process;' :)



src/files/files.cpp
<https://reviews.apache.org/r/34984/#comment138947>

    s/Path/path/


- Niklas Nielsen


On June 4, 2015, 2:40 a.m., Aditi Dixit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34984/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 2:40 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2277
>     https://issues.apache.org/jira/browse/MESOS-2277
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added help for files
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp ce02411c5e579d7551b4325ec141fd89e4ee7255 
> 
> Diff: https://reviews.apache.org/r/34984/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 34984: Added help for files

Posted by Aditi Dixit <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34984/
-----------------------------------------------------------

(Updated June 4, 2015, 9:40 a.m.)


Review request for mesos, Niklas Nielsen and Vinod Kone.


Changes
-------

Fixed issues


Bugs: MESOS-2277
    https://issues.apache.org/jira/browse/MESOS-2277


Repository: mesos


Description
-------

Added help for files


Diffs (updated)
-----

  src/files/files.cpp ce02411c5e579d7551b4325ec141fd89e4ee7255 

Diff: https://reviews.apache.org/r/34984/diff/


Testing
-------

make check


Thanks,

Aditi Dixit