You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by "bkmgit (via GitHub)" <gi...@apache.org> on 2024/01/07 01:35:06 UTC
[PR] Use new Ruby and Nodejs versions [arrow-site]
bkmgit opened a new pull request, #453:
URL: https://github.com/apache/arrow-site/pull/453
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use new Ruby and Nodejs versions [arrow-site]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #453:
URL: https://github.com/apache/arrow-site/pull/453#discussion_r1443894382
##########
.github/workflows/deploy.yml:
##########
@@ -56,7 +55,8 @@ jobs:
echo "ORIGIN=${owner}/${repository}" >> ${GITHUB_ENV}
echo "TARGET_BRANCH=gh-pages" >> ${GITHUB_ENV}
# "url:" is for the opengraph tags, and it can't be relative
- echo "url: https://${owner}.github.io/${repository}" >> _extra_config.yml
+ echo "url: https://${owner}.github.io" >> _extra_config.yml
+ echo "baseurl: /${repository}" >> _extra_config.yml
Review Comment:
We have `JEKYLL_BASE_URL` for it: https://github.com/apache/arrow-site/blob/90107a822a97f69da6b1999fd44bd9dfa2ab8bee/Rakefile#L54-L55
Why do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use new Ruby and Nodejs versions [arrow-site]
Posted by "bkmgit (via GitHub)" <gi...@apache.org>.
bkmgit commented on code in PR #453:
URL: https://github.com/apache/arrow-site/pull/453#discussion_r1443898417
##########
.github/workflows/deploy.yml:
##########
@@ -56,7 +55,8 @@ jobs:
echo "ORIGIN=${owner}/${repository}" >> ${GITHUB_ENV}
echo "TARGET_BRANCH=gh-pages" >> ${GITHUB_ENV}
# "url:" is for the opengraph tags, and it can't be relative
- echo "url: https://${owner}.github.io/${repository}" >> _extra_config.yml
+ echo "url: https://${owner}.github.io" >> _extra_config.yml
+ echo "baseurl: /${repository}" >> _extra_config.yml
Review Comment:
Thanks. Updated. Preview at:
https://bkmgit.github.io/arrow-site/
due to
https://github.com/bkmgit/arrow-site/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use new Ruby and Nodejs versions [arrow-site]
Posted by "bkmgit (via GitHub)" <gi...@apache.org>.
bkmgit commented on PR #453:
URL: https://github.com/apache/arrow-site/pull/453#issuecomment-1880353260
It seems to build. This is not needed.
https://github.com/bkmgit/arrow-site/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use new Ruby and Nodejs versions [arrow-site]
Posted by "bkmgit (via GitHub)" <gi...@apache.org>.
bkmgit closed pull request #453: Use new Ruby and Nodejs versions
URL: https://github.com/apache/arrow-site/pull/453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use new Ruby and Nodejs versions [arrow-site]
Posted by "bkmgit (via GitHub)" <gi...@apache.org>.
bkmgit closed pull request #453: Use new Ruby and Nodejs versions
URL: https://github.com/apache/arrow-site/pull/453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use new Ruby and Nodejs versions [arrow-site]
Posted by "bkmgit (via GitHub)" <gi...@apache.org>.
bkmgit commented on PR #453:
URL: https://github.com/apache/arrow-site/pull/453#issuecomment-1879928068
Closes https://github.com/apache/arrow-site/issues/456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org