You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ol...@apache.org on 2022/10/26 19:36:22 UTC

[sling-org-apache-sling-scripting-groovy] 02/10: [checkstyle] (design) DesignForExtension

This is an automated email from the ASF dual-hosted git repository.

olli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-scripting-groovy.git

commit f034d2df9e638547cf73122e4afe7ae41e3b1872
Author: Oliver Lietz <ol...@apache.org>
AuthorDate: Mon Oct 24 17:17:20 2022 +0200

    [checkstyle] (design) DesignForExtension
---
 .../org/apache/sling/scripting/groovy/internal/GStringScriptEngine.java | 2 +-
 .../sling/scripting/groovy/internal/GStringScriptEngineFactory.java     | 2 +-
 .../scripting/groovy/internal/JsonBuilderBindingsValuesProvider.java    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/sling/scripting/groovy/internal/GStringScriptEngine.java b/src/main/java/org/apache/sling/scripting/groovy/internal/GStringScriptEngine.java
index 0808f6b..65f8ca9 100644
--- a/src/main/java/org/apache/sling/scripting/groovy/internal/GStringScriptEngine.java
+++ b/src/main/java/org/apache/sling/scripting/groovy/internal/GStringScriptEngine.java
@@ -28,7 +28,7 @@ import groovy.lang.Writable;
 import groovy.text.Template;
 import org.apache.sling.scripting.api.AbstractSlingScriptEngine;
 
-public class GStringScriptEngine extends AbstractSlingScriptEngine {
+public final class GStringScriptEngine extends AbstractSlingScriptEngine {
 
     private final GStringScriptEngineFactory scriptEngineFactory;
 
diff --git a/src/main/java/org/apache/sling/scripting/groovy/internal/GStringScriptEngineFactory.java b/src/main/java/org/apache/sling/scripting/groovy/internal/GStringScriptEngineFactory.java
index cf66070..bfecd21 100644
--- a/src/main/java/org/apache/sling/scripting/groovy/internal/GStringScriptEngineFactory.java
+++ b/src/main/java/org/apache/sling/scripting/groovy/internal/GStringScriptEngineFactory.java
@@ -52,7 +52,7 @@ import org.slf4j.LoggerFactory;
     ocd = GStringScriptEngineFactoryConfiguration.class
 )
 @SuppressWarnings("java:S3077")
-public class GStringScriptEngineFactory extends AbstractScriptEngineFactory {
+public final class GStringScriptEngineFactory extends AbstractScriptEngineFactory {
 
     @Reference(
         policy = ReferencePolicy.DYNAMIC,
diff --git a/src/main/java/org/apache/sling/scripting/groovy/internal/JsonBuilderBindingsValuesProvider.java b/src/main/java/org/apache/sling/scripting/groovy/internal/JsonBuilderBindingsValuesProvider.java
index f824657..c76768e 100644
--- a/src/main/java/org/apache/sling/scripting/groovy/internal/JsonBuilderBindingsValuesProvider.java
+++ b/src/main/java/org/apache/sling/scripting/groovy/internal/JsonBuilderBindingsValuesProvider.java
@@ -35,7 +35,7 @@ import org.osgi.service.component.annotations.Component;
 
     }
 )
-public class JsonBuilderBindingsValuesProvider implements BindingsValuesProvider {
+public final class JsonBuilderBindingsValuesProvider implements BindingsValuesProvider {
 
     @Override
     public void addBindings(final Bindings bindings) {