You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by svarnau <gi...@git.apache.org> on 2016/02/19 00:52:24 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1835] Re-factor licen...
GitHub user svarnau opened a pull request:
https://github.com/apache/incubator-trafodion/pull/329
[TRAFODION-1835] Re-factor license files
Enable building license files for source and binary distributions.
Since we build several different distribution packages, the LICENSE
files need to be specific to the components packaged.
The licenses/Makefile indicates how we combine each component source
and binary license files for source package and the various binary
distribution packages.
Binary distribution license info is still incomplete. This change
sets the framework, and license content will be completed later.
Several of the licenses/*-bin files have "To Do" items indicating
remaining work to be done related to TRAFODION-1816.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/svarnau/incubator-trafodion lic1835
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #329
----
commit d6830446562ffafbea4e9fc4c8542f4e2fdee39f
Author: Steve Varnau <st...@esgyn.com>
Date: 2016-02-18T02:23:09Z
[TRAFODION-1835] Re-factor license files
Enable building license files for source and binary distributions.
Since we build several different distribution packages, the LICENSE
files need to be specific to the components packaged.
The licenses/Makefile indicates how we combine each component source
and binary license files for source package and the various binary
distribution packages.
Binary distribution license info is still incomplete. This change
sets the framework, and license content will be completed later.
Several of the licenses/*-bin files have "To Do" items indicating
remaining work to be done related to TRAFODION-1816.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1835] Re-factor licen...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1835] Re-factor licen...
Posted by svarnau <gi...@git.apache.org>.
Github user svarnau commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/329#discussion_r53409882
--- Diff: licenses/Makefile ---
@@ -0,0 +1,46 @@
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+all: LICENSE-src LICENSE-dcs LICENSE-server LICENSE-install LICENSE-rest LICENSE-clients
+
+# All source code included in Trafodion source
+LICENSE-src:
+ cat Apache lic-components-src lic-dcs-src lic-server-src lic-test-src > $@
+
+# Binary licenses for each separtely packaged component
--- End diff --
Fixing now, along with makefile bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1835] Re-factor licen...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/329#discussion_r53406054
--- Diff: licenses/Makefile ---
@@ -0,0 +1,46 @@
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+all: LICENSE-src LICENSE-dcs LICENSE-server LICENSE-install LICENSE-rest LICENSE-clients
+
+# All source code included in Trafodion source
+LICENSE-src:
+ cat Apache lic-components-src lic-dcs-src lic-server-src lic-test-src > $@
+
+# Binary licenses for each separtely packaged component
--- End diff --
Spelling error in comment (fix it later): "separtely"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---