You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2011/04/23 09:31:37 UTC
Review Request: Removed finalizePartition() from the patch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/648/
-----------------------------------------------------------
Review request for hive and Carl Steinbach.
Summary
-------
1. Removed finalizePartition(). Will file separate jira for it.
2. Added container objects for different event types.
3. Changed MetaStoreEventListener from interface to abstract class.
4. Modifications to allow a list of listeners instead of just one.
This addresses bug HIVE-2038.
https://issues.apache.org/jira/browse/HIVE-2038
Diffs
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1096112
trunk/conf/hive-default.xml 1096112
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1096112
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1096112
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1096112
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateDatabaseEvent.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateTableEvent.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropDatabaseEvent.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java PRE-CREATION
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION
Diff: https://reviews.apache.org/r/648/diff
Testing
-------
Thanks,
Ashutosh
Re: Review Request: Removed finalizePartition() from the patch
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/648/
-----------------------------------------------------------
(Updated 2011-04-27 18:32:08.932517)
Review request for hive and Carl Steinbach.
Changes
-------
Identical patch on jira.
Summary
-------
1. Removed finalizePartition(). Will file separate jira for it.
2. Added container objects for different event types.
3. Changed MetaStoreEventListener from interface to abstract class.
4. Modifications to allow a list of listeners instead of just one.
This addresses bug HIVE-2038.
https://issues.apache.org/jira/browse/HIVE-2038
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1096112
trunk/conf/hive-default.xml 1096112
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1096112
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1096112
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1096112
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateDatabaseEvent.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateTableEvent.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropDatabaseEvent.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java PRE-CREATION
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION
Diff: https://reviews.apache.org/r/648/diff
Testing
-------
Thanks,
Ashutosh