You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Anthony Baker (JIRA)" <ji...@apache.org> on 2018/04/20 19:57:32 UTC
[jira] [Closed] (GEODE-4449) Replace macro-templates with plain
templates to allow better debugging
[ https://issues.apache.org/jira/browse/GEODE-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Baker closed GEODE-4449.
--------------------------------
> Replace macro-templates with plain templates to allow better debugging
> ----------------------------------------------------------------------
>
> Key: GEODE-4449
> URL: https://issues.apache.org/jira/browse/GEODE-4449
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: David Kimura
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Replace macro-templates in CacheableBuiltins.hpp from...
> _GEODE_CACHEABLE_ARRAY_TYPE_(int8_t, CacheableBytes);
> _GEODE_CACHEABLE_ARRAY_TYPE_(std::shared_ptr<CacheableString>, CacheableStringArray);
> into...
> using CacheableBytes = CacheableArray<int8_t, GeodeTypeIds::CacheableBytes>;
> using CacheableStringArray = CacheableArray<std::shared_ptr<CacheableString>, GeodeTypeIds::CacheableStringArray>;
> It also makes the code debuggable since most debuggers can step through templates, but not macros. It also removes an unnecessary level of indirection by the preprocessor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)