You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/03 21:58:31 UTC

[GitHub] [tvm] masahi commented on pull request #7023: Save PyTorch frontend state in object

masahi commented on pull request #7023:
URL: https://github.com/apache/tvm/pull/7023#issuecomment-738344230


   Ok I have two questions:
   
   1. What is the distinction between op converters method with `@staticmethod` annotation and the ones without it (the ones which take `self` as argument)?
   2. Can we remove `functools.partial` stuff? So rather than having `def _unary(name, inputs, input_types):` etc, `def _unary(name): return lambda inputs, input_types: ...` Would that be possible?
   
   cc @siju-samuel We will be doing big refactoring of pytorch frontend.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org