You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/23 08:46:34 UTC
[GitHub] [spark] HyukjinKwon commented on issue #25535:
[SPARK-28835][SQL][TEST] Add TPCDSSchema trait
HyukjinKwon commented on issue #25535: [SPARK-28835][SQL][TEST] Add TPCDSSchema trait
URL: https://github.com/apache/spark/pull/25535#issuecomment-524230558
@dbaliafroozeh, can you make sure the PR description and JIRA description are reasonable next time? I put some efforts to make it consistent at https://github.com/apache/spark/commit/0ea8db9fd3d882140d8fa305dd69fc94db62cf8f but seems those were intentionally removed out here.
> ... which can be reused for other testing purposes
I would do such stuff when we actually reuse rather then over-refactoring.
Also, I closed your JIRA before because I didn't know what the JIRA meant. Please just don't copy and paste the description into JIRA next time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org