[GitHub] [lucene] zhaih commented on a change in pull request #485: LUCENE-10010: don't determinize in CompiledAutomaton/RunAutomaton

[GitBox <gi...@apache.org>]

zhaih commented on a change in pull request #485:
URL: https://github.com/apache/lucene/pull/485#discussion_r758815445



##########
File path: lucene/core/src/java/org/apache/lucene/search/AutomatonQuery.java
##########
@@ -65,7 +63,7 @@
    * @param automaton Automaton to run, terms that are accepted are considered a match.
    */
   public AutomatonQuery(final Term term, Automaton automaton) {

Review comment:
       A thing that I'm a little bit worried about is, once this PR is pushed together with #225 (NFA main PR), then a user that previously using this constructor with NFA will not see an exception but a potential performance regression (due to switching from DFA to NFA)? 
   I think this is another reason why I tried to make it "hard" to use the `AutomatonQuery` in NFA mode.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org