You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "chickenlj (via GitHub)" <gi...@apache.org> on 2023/08/09 08:24:07 UTC
[GitHub] [dubbo-go] chickenlj commented on a diff in pull request #2369: Fix zookeeper and nacos issues working as registry, metadata and configcenter
chickenlj commented on code in PR #2369:
URL: https://github.com/apache/dubbo-go/pull/2369#discussion_r1288130647
##########
registry/servicediscovery/service_mapping_change_listener_impl.go:
##########
@@ -63,6 +65,9 @@ func (lstn *ServiceMappingChangedListenerImpl) OnEvent(e observer.Event) error {
err error
reg registry.Registry
)
+
+ lstn.mux.Lock()
Review Comment:
我来加上defer
##########
registry/servicediscovery/service_mapping_change_listener_impl.go:
##########
@@ -63,6 +65,9 @@ func (lstn *ServiceMappingChangedListenerImpl) OnEvent(e observer.Event) error {
err error
reg registry.Registry
)
+
+ lstn.mux.Lock()
Review Comment:
我来加上defer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org