You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/14 17:50:25 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request #4586: Externalize kvm agent storage reboot configuration
GutoVeronezi opened a new pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586
### Description
On KVMHAMonitor, when there is an inconsistency on the heartbeat's file or heartbeat timeout is extrapolated several times, the host is restarted. The host restarting amid several operations might bring inconsistency problems; therefore, it is interesting to let operators choose if they want the host restart or not on the hearbeat's timeout or storage errors.
This PR intends to externalize the heartbeat reboot configuration on KVMHAMonitor. The default value is `true`; therefore, the current behavior is maintained.
This PR depends on [PR#4585](https://github.com/apache/cloudstack/pull/4585).
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functioanlity)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
### How Has This Been Tested?
It has been tested locally on a test lab.
1. On agent, I changed my log4j to debug mode.
2. I added `hearbeat.update.timeout=10` setting to `agent.properties` to force a timeout on hearbeat.
3. I added `reboot.host.and.alert.management.on.hearbeat.timeout` setting to `agent.properties` and changed it some times;
4. I restarted agent and watched the log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-903996016
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-848223941
@DaanHoogland @GabrielBrascher rename done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-761097573
@RodrigoDLopez sure, the new files names will be more intuitive.
I'll do it.
About the normalizations of the names, I understand what you mean, I'll do it too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-896575787
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-889413117
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-895458541
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on a change in pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on a change in pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#discussion_r558347356
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAMonitor.java
##########
@@ -32,17 +33,23 @@
import java.util.concurrent.ConcurrentHashMap;
public class KVMHAMonitor extends KVMHABase implements Runnable {
+
private static final Logger s_logger = Logger.getLogger(KVMHAMonitor.class);
- private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<String, NfsStoragePool>();
+ private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<>();
Review comment:
And if we start to normalize these variable names in this file?
Removing these underscore at the start of any variable. at least where some changes were needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-867602421
@sureshanaparti as I mentioned in https://github.com/apache/cloudstack/pull/4585#issuecomment-850866396, this PR will be rebased if https://github.com/apache/cloudstack/pull/4585 be merged, therefore it still is a WiP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-897061871
<b>Trillian test result (tid-1588)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37995 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4586-t1588-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-896575472
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-903992643
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-895458761
@GutoVeronezi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-882637033
Converting it to draft due to #4585 revertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-892667102
> @RodrigoDLopez did you test this?
Sorry @DaanHoogland I couldn't run the tests yet. I'm having problems with my test environment, but I will run the tests as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-890290585
<b>Trillian test result (tid-1434)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49901 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4586-t1434-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_ping_in_cpvm_success | `Failure` | 15.22 | test_diagnostics.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 352.50 | test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 345.59 | test_routers_network_ops.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 532.46 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-903965365
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-891194194
<b>Trillian test result (tid-1446)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33833 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4586-t1446-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#discussion_r680710284
##########
File path: agent/conf/agent.properties
##########
@@ -270,3 +270,6 @@ iscsi.session.cleanup.enabled=false
# This parameter specifies the heartbeat update timeout in ms; The default value is 60000ms (1 min).
# Depending on the use case, this timeout might need increasing/decreasing.
# heartbeat.update.timeout=60000
+
+# This parameter specifies if the host must be rebooted when something goes wrong with the heartbeat.
+# reboot.host.and.alert.management.on.heartbeat.timeout=true
Review comment:
ah, you're right. forgot about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-838013500
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-882557227
@DaanHoogland @GabrielBrascher @RodrigoDLopez @sureshanaparti
As https://github.com/apache/cloudstack/pull/4585 was merged, I rebased this one and applied only the real changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-895487941
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-903965215
Thanks for testing @RodrigoDLopez
@GutoVeronezi I think we can kick a new round of tests then should be good to go
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-903996564
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-890788238
test_vpc_redundant is failing all over the open PRs, but running one last time anyway to be as sure as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-882557227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi edited a comment on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi edited a comment on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-889391873
@DaanHoogland @GabrielBrascher @RodrigoDLopez @sureshanaparti
PR #4585 was reverted, therefore I submitted a new work on PR #5239.
Now #5239 was merged, therefore I rebased this one and applied only the real changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-806204282
Can anyone review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-836497219
Packaging result: :heavy_check_mark: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-807124094
> Can anyone review this PR?
I just did, but this is not what you need most, I'll look in the company to find test effort for us, to get this merged. As a general rule we need two lgtm, on of which should have at least tested extensively and the other at least looked at the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#discussion_r601682574
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAMonitor.java
##########
@@ -32,17 +33,23 @@
import java.util.concurrent.ConcurrentHashMap;
public class KVMHAMonitor extends KVMHABase implements Runnable {
+
private static final Logger s_logger = Logger.getLogger(KVMHAMonitor.class);
- private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<String, NfsStoragePool>();
+ private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<>();
Review comment:
you mean
```suggestion
private final Map<String, NfsStoragePool> storagePool = new ConcurrentHashMap<>();
```
@RodrigoDLopez ;)
(will need work in the rest of the file!!!)
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAMonitor.java
##########
@@ -32,17 +33,23 @@
import java.util.concurrent.ConcurrentHashMap;
public class KVMHAMonitor extends KVMHABase implements Runnable {
+
private static final Logger s_logger = Logger.getLogger(KVMHAMonitor.class);
- private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<String, NfsStoragePool>();
+ private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<>();
+ private final boolean rebootHostAndAlertManagementOnHearbeatTimeout;
- private final String _hostIP; /* private ip address */
+ /* private ip address */
+ private final String _hostIP;
Review comment:
same here
```suggestion
private final String hostIP;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-904300017
<b>Trillian test result (tid-1754)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33182 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4586-t1754-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-889435173
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-889413654
@GutoVeronezi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#discussion_r680259045
##########
File path: agent/conf/agent.properties
##########
@@ -270,3 +270,6 @@ iscsi.session.cleanup.enabled=false
# This parameter specifies the heartbeat update timeout in ms; The default value is 60000ms (1 min).
# Depending on the use case, this timeout might need increasing/decreasing.
# heartbeat.update.timeout=60000
+
+# This parameter specifies if the host must be rebooted when something goes wrong with the heartbeat.
+# reboot.host.and.alert.management.on.heartbeat.timeout=true
Review comment:
@DaanHoogland It's there =)
GitHub warns when there is no newline at the end of the file, e.g.:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#discussion_r639455974
##########
File path: agent/conf/agent.properties
##########
@@ -263,3 +263,6 @@ iscsi.session.cleanup.enabled=false
# Automatically clean up iscsi sessions not attached to any VM.
# Should be enabled for users using managed storage for example solidfire.
# Should be disabled for users with unmanaged iscsi connections on their hosts
+#
+#This parameter specifies if the host must be rebooted when something go wrong with heartbeat.
+# reboot.host.and.alert.management.on.hearbeat.timeout=true
Review comment:
typo `hearbeat` => _heartbeat_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-847043545
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-882557227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#discussion_r680162787
##########
File path: agent/conf/agent.properties
##########
@@ -270,3 +270,6 @@ iscsi.session.cleanup.enabled=false
# This parameter specifies the heartbeat update timeout in ms; The default value is 60000ms (1 min).
# Depending on the use case, this timeout might need increasing/decreasing.
# heartbeat.update.timeout=60000
+
+# This parameter specifies if the host must be rebooted when something goes wrong with the heartbeat.
+# reboot.host.and.alert.management.on.heartbeat.timeout=true
Review comment:
hope the newline is there ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-890320193
<b>Trillian test result (tid-1437)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50106 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4586-t1437-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 88 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 474.21 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi edited a comment on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi edited a comment on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-882637033
Converting it to draft due to #4585 reversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi edited a comment on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi edited a comment on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-882637033
Converting it to draft due to #4585 reversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-903931214
@DaanHoogland @GabrielBrascher @RodrigoDLopez is this good to go? Is there anything else to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#discussion_r639456651
##########
File path: agent/src/main/java/com/cloud/agent/properties/AgentProperties.java
##########
@@ -0,0 +1,58 @@
+/*
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.cloud.agent.properties;
+
+/**
+ * Class of constant agent's properties available to configure on
+ * "agent.properties".
+ *<br><br>
+ * Not all available agent properties are defined here, but we should work to
+ * migrate them on demand to this class.
+ *
+ * @param <T> type of the default value.
+ */
+public class AgentProperties<T>{
+
+ /**
+ * Heartbeat update timeout. <br>
+ * Data type: int. <br>
+ * Default value: 60000 (ms).
+ */
+ public static final AgentProperties<Integer> HEARTBEAT_UPDATE_TIMEOUT = new AgentProperties<Integer>("hearbeat.update.timeout", 60000);
+
Review comment:
check the typo error 'hearbeat', and correct it wherever applicable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#discussion_r639113071
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAMonitor.java
##########
@@ -32,17 +33,23 @@
import java.util.concurrent.ConcurrentHashMap;
public class KVMHAMonitor extends KVMHABase implements Runnable {
+
private static final Logger s_logger = Logger.getLogger(KVMHAMonitor.class);
- private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<String, NfsStoragePool>();
+ private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<>();
+ private final boolean rebootHostAndAlertManagementOnHearbeatTimeout;
- private final String _hostIP; /* private ip address */
+ /* private ip address */
+ private final String _hostIP;
Review comment:
If the contributor decides to proceed with renaming this variable, I would also suggest removing the commented line `/* private IP address */`, and leave simply `hostIP`, or then something as `hostPrivateIP` or `privateIpAddress`, as this is expected to be the `HostVO.privateIpAddress`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-762682091
good work @GutoVeronezi looking forward to see this merged, but I am going to put my foot down for very extensive testing. :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-882569957
@GutoVeronezi we may need to revert #4585 as addHost is failing since it got merged. Not sure what is the issue, still investigating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-903970530
@nvazquez ok, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-882569957
@GutoVeronezi we may need to revert #4585 as addHost is failing since it got merged. Not sure what is the issue, still investigating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-882569957
@GutoVeronezi we may need to revert #4585 as addHost is failing since it got merged. Not sure what is the issue, still investigating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-897884985
I ran some tests with this propose. But I'm not sure about my environment. I couldn't see my kvm agent stop at any point.
anyway, I managed to verify that the behavior of the externalized parameter is in accordance with what was proposed.
forcing my heartbeat timeout on two kvm hosts it's possible to see that the ones without the parameter `reboot.host.and.alert.management.on.heartbeat.timeout=false` will log the mensage `failed: timeout; stopping cloudstack-agent.`
**Kvm-nd01**
```
heartbeat.update.timeout=10
reboot.host.and.alert.management.on.heartbeat.timeout=true
```
```
Thread-1:null) (logid:) The command (/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/kvmheartbeat.sh -i 201.200.102.10 -p /export/primary -m /mnt/0727b905-35cb-36cb-961c-ea27b1a83333 -h 201.200.101.3 ), to the pool [0727b905-35cb-36cb-961c-ea27b1a83333], has the result [timeout].
(Thread-1:null) (logid:) Write heartbeat for pool [0727b905-35cb-36cb-961c-ea27b1a83333] failed: timeout; try: 5 of 5.
(Thread-1:null) (logid:) [IGNORED] Interrupted between heartbeat retries.
java.lang.InterruptedException: sleep interrupted
at java.base/java.lang.Thread.sleep(Native Method)
at com.cloud.hypervisor.kvm.resource.KVMHAMonitor.runHeartBeat(KVMHAMonitor.java:129)
at com.cloud.hypervisor.kvm.resource.KVMHAMonitor.run(KVMHAMonitor.java:176)
at java.base/java.lang.Thread.run(Thread.java:829)
(Thread-1:null) (logid:) Write heartbeat for pool [0727b905-35cb-36cb-961c-ea27b1a83333] failed: timeout; stopping cloudstack-agent.
```
**Kvm-nd02**
```
heartbeat.update.timeout=10
reboot.host.and.alert.management.on.heartbeat.timeout=false
```
```
(Thread-1:null) (logid:) The command (/usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/kvmheartbeat.sh -i 201.200.102.10 -p /export/primary -m /mnt/0727b905-35cb-36cb-961c-ea27b1a83333 -h 201.200.101.4 ), to the pool [0727b905-35cb-36cb-961c-ea27b1a83333], has the result [timeout].
(Thread-1:null) (logid:) Write heartbeat for pool [0727b905-35cb-36cb-961c-ea27b1a83333] failed: timeout; try: 5 of 5.
(Thread-1:null) (logid:) [IGNORED] Interrupted between heartbeat retries.
java.lang.InterruptedException: sleep interrupted
at java.base/java.lang.Thread.sleep(Native Method)
at com.cloud.hypervisor.kvm.resource.KVMHAMonitor.runHeartBeat(KVMHAMonitor.java:129)
at com.cloud.hypervisor.kvm.resource.KVMHAMonitor.run(KVMHAMonitor.java:176)
at java.base/java.lang.Thread.run(Thread.java:829)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-889391873
@DaanHoogland @GabrielBrascher @RodrigoDLopez @sureshanaparti
As #5239 was merged, I rebased this one and applied only the real changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-891249394
@RodrigoDLopez did you test this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-867595815
@GutoVeronezi is this PR ready for review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-892667102
> @RodrigoDLopez did you test this?
Sorry @DaanHoogland I couldn't run the tests yet. I'm having problems with my test environment, but I will run the tests as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi edited a comment on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
GutoVeronezi edited a comment on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-882637033
Converting it to draft due to #4585 reversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-771006635
nice job @GutoVeronezi
Code LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-837216495
Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4586: Externalize kvm agent storage reboot configuration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-897359233
> > @RodrigoDLopez did you test this?
>
> Sorry @DaanHoogland I couldn't run the tests yet. I'm having problems with my test environment, but I will run the tests as soon as possible.
@RodrigoDLopez anything to share yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org