You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/15 14:20:26 UTC
[GitHub] [spark] linhongliu-db opened a new pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
linhongliu-db opened a new pull request #34603:
URL: https://github.com/apache/spark/pull/34603
### What changes were proposed in this pull request?
This is a follow-up of PR #34546 which uses the `AnalysisContext` to store referred
temporary functions when creating temp views. But the `CacheTableAsSelect` also
needs to update the temporary functions because it's a temp view under the hood.
### Why are the changes needed?
Followup of #34546
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
newly added ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-971117036
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49766/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-969063761
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49709/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-971142240
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49766/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-971041286
**[Test build #145296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145296/testReport)** for PR 34603 at commit [`a213518`](https://github.com/apache/spark/commit/a2135180f5446bd4352656ff80917ee7fb412558).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-968963740
**[Test build #145239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145239/testReport)** for PR 34603 at commit [`ebe1a65`](https://github.com/apache/spark/commit/ebe1a659dd321d2c8fb47b57db237e16f1b0c79d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34603:
URL: https://github.com/apache/spark/pull/34603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-971238512
**[Test build #145296 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145296/testReport)** for PR 34603 at commit [`a213518`](https://github.com/apache/spark/commit/a2135180f5446bd4352656ff80917ee7fb412558).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-968963740
**[Test build #145239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145239/testReport)** for PR 34603 at commit [`ebe1a65`](https://github.com/apache/spark/commit/ebe1a659dd321d2c8fb47b57db237e16f1b0c79d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] linhongliu-db commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
linhongliu-db commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-969693182
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-971243355
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145296/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-969079685
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49709/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-969079685
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49709/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34603:
URL: https://github.com/apache/spark/pull/34603#discussion_r749986111
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala
##########
@@ -1643,4 +1643,12 @@ class CachedTableSuite extends QueryTest with SQLTestUtils
}
}
}
+
+ test("SPARK-37702: cache table with temporary function ") {
+ spark.udf.register("udf", (id: Int) => id + 1)
Review comment:
let's wrap with `withUserDefinedFunction`, so that we can unregister the function at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-969003408
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49709/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-969241577
**[Test build #145239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145239/testReport)** for PR 34603 at commit [`ebe1a65`](https://github.com/apache/spark/commit/ebe1a659dd321d2c8fb47b57db237e16f1b0c79d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-969243226
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145239/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-971041286
**[Test build #145296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145296/testReport)** for PR 34603 at commit [`a213518`](https://github.com/apache/spark/commit/a2135180f5446bd4352656ff80917ee7fb412558).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] linhongliu-db commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
linhongliu-db commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-971605525
@wangyum thanks for reporting. fixed in PR #34633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-969243226
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145239/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-971243355
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145296/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-971138045
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49766/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-971188792
thanks, merging to master/3.2!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-971142240
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49766/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #34603: [SPARK-37702][SQL][FOLLOWUP] Store referred temp functions for CacheTableAsSelect
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #34603:
URL: https://github.com/apache/spark/pull/34603#issuecomment-971315741
@linhongliu-db t seems this PR makes branch-3.2 test fail.
```
[info] *** 1 TEST FAILED ***
[error] Failed: Total 6479, Failed 1, Errors 0, Passed 6478, Ignored 5
[error] Failed tests:
[error] org.apache.spark.sql.catalyst.parser.DDLParserSuite
```
https://github.com/apache/spark/runs/4234087768?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org