You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Tzvetanov Grigorov (Jira)" <ji...@apache.org> on 2021/07/19 19:23:00 UTC
[jira] [Comment Edited] (WICKET-6905) CLONE - WS broadcast of
ClosedMessage rewrites touchedPages by its single page
[ https://issues.apache.org/jira/browse/WICKET-6905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383530#comment-17383530 ]
Martin Tzvetanov Grigorov edited comment on WICKET-6905 at 7/19/21, 7:22 PM:
-----------------------------------------------------------------------------
SPAM
Same user attached few (virus ?!) files to https://issues.apache.org/jira/browse/INFRA-21874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
was (Author: mgrigorov):
SPAM
> CLONE - WS broadcast of ClosedMessage rewrites touchedPages by its single page
> ------------------------------------------------------------------------------
>
> Key: WICKET-6905
> URL: https://issues.apache.org/jira/browse/WICKET-6905
> Project: Wicket
> Issue Type: Bug
> Components: wicket-native-websocket
> Affects Versions: 7.7.0, 8.7.0
> Environment: Java 8, Tomcat 9.0.27 and Jetty 9.4.18, Firefox 75.0
> Reporter: Jessica norris
> Assignee: Martin Tzvetanov Grigorov
> Priority: Minor
>
> That causes a lost of instances of newly touched pages (within PageStoreManager). For quite specific scenario that could have *visible* impact.
> *Conditions* to be fulfilled to see effect:
> # calling setResponsePage(new NewResponsePage(customParams)) within AjaxLink (Link works)
> ** this instance of passed page is not used for rendering (customParams are lost) - page is overridden by AbstractWebSocketProcessor.onClose() - within PersistentRequestAdapter.storeTouchedPages()
> # RenderStrategy.{color:#660e7a}REDIRECT_TO_RENDER{color} must be applied
> ** otherwise it is rendered before AbstractWebSocketProcessor.onClose()
> # VoidPageManagerProvider must be used - setPageManagerProvider({color:#000080}new {color}VoidPageManagerProvider({color:#000080}this{color}));
> ** otherwise it is saved and loaded within PageManager not only in session
> I'm attaching *test application* with example of losing page instance (and passed arguments). Important lines marked {color:#FF0000}NOT WORKING{color} in java and html files.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)