[jira] [Comment Edited] (KARAF-3148) Extract common part of karaf bin scripts to a separate file to avoid duplication

["Dmitry Konstantinov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084769#comment-14084769 ] 

Dmitry Konstantinov edited comment on KARAF-3148 at 8/4/14 3:26 PM:
--------------------------------------------------------------------

For example:

{code}
detectOS() {
    # OS specific support (must be 'true' or 'false').
    cygwin=false;
    darwin=false;
    aix=false;
    os400=false;
    case "`uname`" in
        CYGWIN*)
            cygwin=true
            ;;
        Darwin*)
            darwin=true
            ;;
        AIX*)
            aix=true
            ;;
        OS400*)
            os400=true
            ;;
    esac
    # For AIX, set an environment variable
    if $aix; then
         export LDR_CNTRL=MAXDATA=0xB0000000@DSA
         echo $LDR_CNTRL
    fi
} 
{code}
I found the definition in stop, start, karaf, status, shell, instance, client scripts.


was (Author: dnk):
For example:

detectOS() {
    # OS specific support (must be 'true' or 'false').
    cygwin=false;
    darwin=false;
    aix=false;
    os400=false;
    case "`uname`" in
        CYGWIN*)
            cygwin=true
            ;;
        Darwin*)
            darwin=true
            ;;
        AIX*)
            aix=true
            ;;
        OS400*)
            os400=true
            ;;
    esac
    # For AIX, set an environment variable
    if $aix; then
         export LDR_CNTRL=MAXDATA=0xB0000000@DSA
         echo $LDR_CNTRL
    fi
} 

I found the definition in stop, start, karaf, status, shell, instance, client scripts.

> Extract common part of karaf bin scripts to a separate file to avoid duplication
> --------------------------------------------------------------------------------
>
>                 Key: KARAF-3148
>                 URL: https://issues.apache.org/jira/browse/KARAF-3148
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 3.0.1, 2.3.6
>            Reporter: Dmitry Konstantinov
>            Assignee: Jean-Baptiste Onofré
>            Priority: Minor
>
> It make sense to extract the following functions to a separate file and reuse them:
>     # Determine if there is special OS handling we must perform
>     detectOS
>     # Unlimit the number of file descriptors if possible
>     unlimitFD
>     # Locate the Karaf home directory
>     locateHome
>     # Locate the Karaf base directory
>     locateBase
>     # Locate the Karaf data directory
>     locateData
>     # Setup the native library path
>     setupNativePath
>     # Locate the Java VM to execute
>     locateJava
>     # Determine the JVM vendor
>     detectJVM
>     # Setup default options
>     setupDefaults



--
This message was sent by Atlassian JIRA
(v6.2#6252)