[jira] [Commented] (IMPALA-8390) test_cancel_insert and test_cancel_sort broken

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816805#comment-16816805 ] 

ASF subversion and git services commented on IMPALA-8390:
---------------------------------------------------------

Commit a4ad8f35f7768ac608317e702fdbd3a042140186 in impala's branch refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a4ad8f3 ]

IMPALA-8390: clean up test vectors in test_cancellation.py

Due to changes to TestCancellation made in IMPALA-7205 that were not
reflected in TestCancellationSerial and TestCancellationFullSort,
test_cancel_insert has not been running at all and test_cancel_sort
has been running with unintended parameters.

This patch re-enables test_cancel_insert, while including a number of
constraints on its parameters to keep test execution time reasonable.
It also fixes an incorrect constraint on test_cancel_sort.

The patch also makes some related improvements:
- Removes an xfail on test_cancel_insert related to a bug that is
  fixed now.
- When ImpalaTestVector.get_value() is called with a value name that
  does not actually exist in the vector, the result is a StopIteration
  exception. Due to python's questionable habit of using exceptions
  for flow control, StopIteration is frequently treated not as an
  error but as the normal end of iteration, which can result in
  unexpected behavior, eg. when pytest_generate_tests raises a
  StopIteration pytest just silently ignores it and drops the test
  case. This patch modifies get_value() to instead raise a ValueError
  in this situation.
- When a test has no vectors generated for it, the name of the test is
  now included in the logged warning.

Testing:
- Ran full core and exhaustive runs and verified that the expected
  test cases are run for test_cancellation.py now

Change-Id: I9673fe82bda5314aff6a51d1961759ff286fbf6f
Reviewed-on: http://gerrit.cloudera.org:8080/12960
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> test_cancel_insert and test_cancel_sort broken
> ----------------------------------------------
>
>                 Key: IMPALA-8390
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8390
>             Project: IMPALA
>          Issue Type: Bug
>            Reporter: Thomas Tauber-Marshall
>            Assignee: Thomas Tauber-Marshall
>            Priority: Critical
>
> The tests test_cancel_insert and test_cancel_sort in test_cancellation.py are both broken due to specifying a test dimension 'action' which was renamed as part of IMPALA-7205
> More generally, test_cancellation.py has a large number of test dimensions that blow up into a huge test matrix and we should probably think through what combinations of tests are actually giving us the coverage we want



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org