You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Mark Ford (JIRA)" <ji...@apache.org> on 2010/12/31 15:13:46 UTC

[jira] Created: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Contribute camel-sns component to the new camel-aws component.
--------------------------------------------------------------

                 Key: CAMEL-3476
                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
             Project: Camel
          Issue Type: New Feature
    Affects Versions: 2.6.0
            Reporter: Mark Ford
            Priority: Minor


CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 

This code is currently hosted as a google code project here:

http://code.google.com/p/camel-sns/

I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979933#action_12979933 ] 

Tracy Snell commented on CAMEL-3476:
------------------------------------

Christian I'll merge up the two components and submit a new patch.

Thanks Mark!

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Tracy Snell
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tracy Snell reassigned CAMEL-3476:
----------------------------------

    Assignee: Tracy Snell  (was: Christian Müller)

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Tracy Snell
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982041#action_12982041 ] 

Claus Ibsen commented on CAMEL-3476:
------------------------------------

@author tags should also be removed.

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-aws
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt, patchfile.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982042#action_12982042 ] 

Claus Ibsen commented on CAMEL-3476:
------------------------------------

Please adjust logging to a sensible level DEBUG is to verbost. Adjust some of the DEBUG to TRACE level.

For example debug logging "Starting" doesnt provide much value. Instead log maybe at INFO level that the consumer is starting and listening on XXX endpoint / queue or whatever it listen. Likewise when it stops. 

Camel core itself has logging when it starts/stops consumers/producer etc so we got plenty of generic logging for that.

Loading resources / classes from classpath should *always* use the API from CamelContext. There is a ClassResolver. It ensures it can be loaded in OSGI, JBoss and whatever platform
{code}
 String s = IOUtils.toString(SnsConsumer.class.getResourceAsStream("/default-sqs-policy-template.json"));
{code}

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-aws
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt, patchfile.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982100#action_12982100 ] 

Christian Müller commented on CAMEL-3476:
-----------------------------------------

We will add this new component into Camel 2.7. Hadrian will start building the release in the next couple of days...
I will have a look on it next week.

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-aws
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt, patchfile.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979611#action_12979611 ] 

Tracy Snell commented on CAMEL-3476:
------------------------------------

Code repacked. Some minor tweaks. Ready for Mark to submit.

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.7.0
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981908#action_12981908 ] 

Tracy Snell commented on CAMEL-3476:
------------------------------------

Made a number of changes to the code. Added several new classes. Improved and added some tests.

Code coverage is high with integration testing on. More tests I'll add later when I look for areas of reuse between the 2 components. Should build clean and pass sourcecheck.

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-aws
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Tracy Snell
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt, patchfile.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976427#action_12976427 ] 

Tracy Snell commented on CAMEL-3476:
------------------------------------

I've repackaged the code in prep for Mark to submit it but waiting on Amazon to figure out my SNS access issue to confirm tests.

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982040#action_12982040 ] 

Claus Ibsen commented on CAMEL-3476:
------------------------------------

And it would be good to avoid system out but using logger, even in unit tests.

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-aws
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt, patchfile.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-3476:
-------------------------------

    Fix Version/s: 2.7.0

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.7.0
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tracy Snell updated CAMEL-3476:
-------------------------------

    Attachment: patchfile.txt

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-aws
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Tracy Snell
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt, patchfile.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tracy Snell reassigned CAMEL-3476:
----------------------------------

    Assignee: Christian Müller  (was: Tracy Snell)

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-aws
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt, patchfile.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982098#action_12982098 ] 

Tracy Snell commented on CAMEL-3476:
------------------------------------

- Almost removed the System.out calls from the tests then I wasn't sure if they were allowed or not. Pulling them.
- Colon for Headers can be removed. I went with Mark's convention there thinking it'd be OK.
- I saw a few other @author tags in the tree so left it in. Didn't want to be pulling the original author's name if it was allowed. :)
- I'll adjust logging
- Fixing the resource loading.

If this is not going out in 2.6 I think I'll merge back into Mark's google code repository. He has some test enhancements he'd like to add. Then we can resubmit the patch.


> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-aws
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt, patchfile.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-3476:
-------------------------------

    Component/s: camel-aws

Please prefix the component scheme name with {{aws-}} so it would be {{aws-sns}}.
This is done by naming the file {{aws-sns}} in the META-INF/services/ ... /components directory.

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-aws
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Tracy Snell
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982103#action_12982103 ] 

Christian Müller commented on CAMEL-3476:
-----------------------------------------

Perfect.

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-aws
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt, patchfile.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982039#action_12982039 ] 

Claus Ibsen commented on CAMEL-3476:
------------------------------------

The keys for the headers can we avoid the colon?
{code}
 String SNS_SUBJECT = "SNS:Subject";
{code}

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-aws
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt, patchfile.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982101#action_12982101 ] 

Tracy Snell commented on CAMEL-3476:
------------------------------------

I've made the changes Claus recommended. I'm going to push the code back into google code so Mark can review and add the improvements he was thinking. Then we'll get a new patch here early in the week. That work?

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-aws
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt, patchfile.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Mark Ford (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Ford updated CAMEL-3476:
-----------------------------

    Attachment: camel-aws-3476.txt

Attached is my camel-sns contribution that has been repackaged by Tracy Snell. This code should be merged with the camel-aws contribution in order to leverage code between the SQS and SNS components.

Note that some of the integration tests with SNS are slow due to the delay involved in propagating the permissions for the target queue. At one point the advertised propagation time was 60 seconds but in practice it was over 90 seconds. All of the integration tests that rely on this propagation wait 120 seconds to be sure. A better approach would be to setup a single queue for the integration tests and reuse it for all of the tests. This is left for a future submission (i.e. from Tracy).

Additionally, some of the suggestions for the SQS component submission apply here as well. For example, the setting of the Amazon API object, public key, etc would be nice improvements. 

There are a few FIXME's left undone but they don't affect the functionality. One is a minor tweak and two are missing tests. I'm submitting as is in the interest of making it available for others to work on if interested.

Enjoy



> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tracy Snell updated CAMEL-3476:
-------------------------------

    Attachment: patchfile.txt

Should be close now. Give it a look and let me know if I missed anything.

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-aws
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt, patchfile.txt, patchfile.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980958#action_12980958 ] 

Christian Müller commented on CAMEL-3476:
-----------------------------------------

Ok, sounds good. Looking forward for it...

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Tracy Snell
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: camel-aws-3476.txt
>
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CAMEL-3476) Contribute camel-sns component to the new camel-aws component.

Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Müller reassigned CAMEL-3476:
---------------------------------------

    Assignee: Christian Müller

> Contribute camel-sns component to the new camel-aws component.
> --------------------------------------------------------------
>
>                 Key: CAMEL-3476
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3476
>             Project: Camel
>          Issue Type: New Feature
>    Affects Versions: 2.6.0
>            Reporter: Mark Ford
>            Assignee: Christian Müller
>            Priority: Minor
>
> CAMEL-3468 contributes a new component for interacting with the Amazon SQS service. The camel-sns component allows users to publish/subscribe to topics on Amazon's Simple Notification Service. 
> This code is currently hosted as a google code project here:
> http://code.google.com/p/camel-sns/
> I'll coordinate with Tracy (developer of camel-aws) in the creation of the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.