You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pankajkoti (via GitHub)" <gi...@apache.org> on 2023/11/14 08:29:20 UTC
[PR] Extend task context logging support for remote logging using WASB (Azure Blob Storage) [airflow]
pankajkoti opened a new pull request, #32972:
URL: https://github.com/apache/airflow/pull/32972
With the addition of task context logging feature in PR #32646,
this PR extends the feature to Azure Blob Storage (WASB) when
is it set as remote logging store. Here, backward compatibility is
ensured for older versions of Airflow that do not have the feature
included in Airflow Core.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend task context logging support for remote logging using WASB (Azure Blob Storage) [airflow]
Posted by "pankajkoti (via GitHub)" <gi...@apache.org>.
pankajkoti merged PR #32972:
URL: https://github.com/apache/airflow/pull/32972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend task context logging support for remote logging using WASB (Azure Blob Storage) [airflow]
Posted by "pankajkoti (via GitHub)" <gi...@apache.org>.
pankajkoti commented on PR #32972:
URL: https://github.com/apache/airflow/pull/32972#issuecomment-1816508964
Run of latest successful testing fetching logs from Azure WASB task failures due to task marked failed by scheduler after being detected as a zombie
<img width="1711" alt="Screenshot 2023-11-17 at 7 45 48 PM" src="https://github.com/apache/airflow/assets/10206082/3c65921f-560c-423a-8f5f-595b0e66e730">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend task context logging support for remote logging using WASB (Azure Blob Storage) [airflow]
Posted by "pankajkoti (via GitHub)" <gi...@apache.org>.
pankajkoti commented on code in PR #32972:
URL: https://github.com/apache/airflow/pull/32972#discussion_r1397216657
##########
airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -32,7 +32,7 @@
if TYPE_CHECKING:
import logging
-
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pankajkoti commented on pull request #32972: Extend task context logging support for remote logging using WASB (Azure Blob Storage)
Posted by "pankajkoti (via GitHub)" <gi...@apache.org>.
pankajkoti commented on PR #32972:
URL: https://github.com/apache/airflow/pull/32972#issuecomment-1658747227
Backward compatibility test by putting this change on top of main branch locally:
<img width="1696" alt="Screenshot 2023-07-31 at 9 23 42 PM" src="https://github.com/apache/airflow/assets/10206082/1e27d098-de60-443f-85dc-3ba9680c7652">
**Feature testing by putting these changes on the base PR branch which adds the feature in Airflow Core:**
Without this change for WASB remote logging when tasks fail in scheduler:
<img width="1692" alt="Screenshot 2023-07-31 at 9 24 06 PM" src="https://github.com/apache/airflow/assets/10206082/9814e9d1-c4b2-47e2-ba28-795bd443a2db">
With this change for WASB remote logging when tasks fail in scheduler:
<img width="1707" alt="Screenshot 2023-07-31 at 9 32 53 PM" src="https://github.com/apache/airflow/assets/10206082/4749a18e-2e20-4ef0-9f62-de7464b41bd3">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend task context logging support for remote logging using WASB (Azure Blob Storage) [airflow]
Posted by "pankajkoti (via GitHub)" <gi...@apache.org>.
pankajkoti commented on code in PR #32972:
URL: https://github.com/apache/airflow/pull/32972#discussion_r1397216069
##########
airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -32,7 +32,6 @@
if TYPE_CHECKING:
import logging
Review Comment:
```suggestion
import logging
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend task context logging support for remote logging using WASB (Azure Blob Storage) [airflow]
Posted by "pankajkoti (via GitHub)" <gi...@apache.org>.
pankajkoti commented on code in PR #32972:
URL: https://github.com/apache/airflow/pull/32972#discussion_r1397216657
##########
airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -32,7 +32,7 @@
if TYPE_CHECKING:
import logging
-
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #32972: Extend task context logging support for remote logging using WASB (Azure Blob Storage)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32972:
URL: https://github.com/apache/airflow/pull/32972#issuecomment-1720310514
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #32972: Extend task context logging support for remote logging using WASB (Azure Blob Storage)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #32972: Extend task context logging support for remote logging using WASB (Azure Blob Storage)
URL: https://github.com/apache/airflow/pull/32972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend task context logging support for remote logging using WASB (Azure Blob Storage) [airflow]
Posted by "pankajkoti (via GitHub)" <gi...@apache.org>.
pankajkoti commented on code in PR #32972:
URL: https://github.com/apache/airflow/pull/32972#discussion_r1397218649
##########
airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -32,7 +32,6 @@
if TYPE_CHECKING:
import logging
Review Comment:
```suggestion
import logging
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Extend task context logging support for remote logging using WASB (Azure Blob Storage) [airflow]
Posted by "pankajkoti (via GitHub)" <gi...@apache.org>.
pankajkoti commented on code in PR #32972:
URL: https://github.com/apache/airflow/pull/32972#discussion_r1397217583
##########
airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -32,7 +32,7 @@
if TYPE_CHECKING:
import logging
-
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org